refactor (api-server) better connection errors handling

 - make more user friendly connection errors logging
 - rename ServerCodeService => ApiServerService

Author: vengrov

lib/server-code/runners/debug.js

@@ -1,13 +1,13 @@
 'use strict';
 
-const logger             = require('../../util/logger'),
-      file               = require('../../util/file'),
-      redis              = require('redis'),
-      promiseWhile       = require('../../util/promise').promiseWhile,
-      denodeify          = require('../../util/promise').denodeify,
-      ServerCodeService  = require('../services/server-code'),
-      tasksExecutor      = require('./tasks/executor'),
-      ServerCodeModel    = require('../model');
+const logger           = require('../../util/logger'),
+      file             = require('../../util/file'),
+      redis            = require('redis'),
+      promiseWhile     = require('../../util/promise').promiseWhile,
+      denodeify        = require('../../util/promise').denodeify,
+      ApiServerService = require('../services/api-server'),
+      tasksExecutor    = require('./tasks/executor'),
+      ServerCodeModel  = require('../model');
 
 const TASKS_AWAIT_TIMEOUT = 10;
 const SESSION_TTL = 60;
@@ -53,7 +53,7 @@ class TaskAcquirer {
 class DebugCodeRunner {
   constructor(opts) {
     this.options = opts;
-    this.scs = new ServerCodeService(opts.app, opts.backendless.apiServer);
+    this.apiServer = new ApiServerService(opts.app, opts.backendless.apiServer);
 
     this.messageBroker = new ThenRedis(opts.backendless.msgBroker);
     this.model = this.buildModel();
@@ -103,7 +103,7 @@ class DebugCodeRunner {
       }
 
       if (this.debugSessionId) {
-        this.scs.unregisterRunner();
+        this.apiServer.unregisterRunner();
         this.messageBroker.del(this.debugSessionId);
       }
 
@@ -115,22 +115,22 @@ class DebugCodeRunner {
   }
 
   registerHandlers() {
-    return this.scs.registerModel(this.model);
+    return this.apiServer.registerModel(this.model);
   }
 
   registerServices() {
     const services = this.model.services.values();
 
     if (services.length) {
-      return this.scs.unregisterDebugServices()
+      return this.apiServer.unregisterDebugServices()
         .then(() => Promise.all(services.map((s) => {
-          return this.scs.registerDebugService(this.model.describeService(s.name));
+          return this.apiServer.registerDebugService(this.model.describeService(s.name));
         })));
     }
   }
 
   registerRunner() {
-    return this.scs.registerRunner()
+    return this.apiServer.registerRunner()
       .then(debugId => (this.debugSessionId = debugId));
   }
 

lib/server-code/services/server-code.js renamed to lib/server-code/services/api-server.js

@@ -16,7 +16,7 @@ function parseError(res) {
     || `Status Code ${res.statusCode} (${res.statusMessage})`;
 }
 
-class ServerCodeService {
+class ApiServerService {
   constructor(app, serverUrl) {
     this.app = app;
     this.serverUrl = serverUrl;
@@ -34,7 +34,11 @@ class ServerCodeService {
       headers: this.appHeaders
     }, options);
 
-    return request(options);
+    return request(options).catch((err) => {
+      logger.error(`Connection attempt failed with ${err.message}`);
+
+      throw new Error('Could not connect to Backendless API Server');
+    });
   }
 
   registerModel(model) {
@@ -146,4 +150,4 @@ class ServerCodeService {
   }
 }
 
-module.exports = ServerCodeService;
+module.exports = ApiServerService;