Add pretty url to server details link

Author: carlbennett

src/libraries/Server.php

@@ -148,6 +148,16 @@ public function getTypeId() {
     return $this->type_id;
   }
 
+  public function getURI() {
+    $value = $this->getLabel();
+    if (empty($value)) {
+      $value = $this->getAddress() . ":" . $this->getPort();
+    }
+    return Common::relativeUrlToAbsolute(
+      "/server/" . $this->getId() . "/" . Common::sanitizeForUrl($value, true)
+    );
+  }
+
   public function getUpdatedDateTime() {
     if (is_null($this->updated_datetime)) {
       return $this->updated_datetime;

src/templates/Servers.phtml

@@ -55,7 +55,7 @@ require("./header.inc.phtml");
                 <td class="status center <?php echo $status_subclass; ?>"><?php echo $status; ?></td>
                 <td class="label"><?php echo ($server->getLabel() != $server->getAddress() && !is_null($server->getLabel()) ? $server->getLabel() : "&nbsp;"); ?></td>
                 <td class="address" onclick="bnetdocs.fSelectText(this);"><?php echo $server->getAddress(); ?>:<?php echo $server->getPort(); ?></td>
-                <td class="details center"><a href="<?php echo Common::relativeUrlToAbsolute("/server/" . $server->getId()); ?>">View Details</a></td>
+                <td class="details center"><a href="<?php echo $server->getURI(); ?>">View Details</a></td>
               </tr>
 <?php   } ?>
 <?php } ?>