Remove Rollbar

Author: carlbennett

bin/deploy

@@ -9,7 +9,6 @@ TARGET_FILE="${SOURCE_DIRECTORY}/etc/deploy-targets.csv"
 TARGET_ENV=""
 SKIP_COMPOSER=0
 SKIP_CONFIRM=0
-ROLLBAR_ACCESS_TOKEN="$(cat ${SOURCE_DIRECTORY}/etc/.rollbar-token)"
 
 # Parameter handling
 OPTIND=1
@@ -70,7 +69,7 @@ fi
 # Break on non-success exit codes
 set -e
 
-printf "[1/5] Running composer update...\n"
+printf "[1/4] Running composer update...\n"
 if [ "${SKIP_COMPOSER}" -ne 1 ]; then
     if [ "${TARGET_ENV}" == "production" ]; then
         composer update -o --no-dev
@@ -81,7 +80,7 @@ else
     printf "skipping step as requested...\n"
 fi
 
-printf "[2/5] Generating version information...\n"
+printf "[2/4] Generating version information...\n"
 # Version identifier
 printf "$(git describe --always --tags)\n" \
   > ${SOURCE_DIRECTORY}/etc/.rsync-version
@@ -95,14 +94,7 @@ printf "$(git log -n 1 --pretty='%aI' HEAD)\n" \
 printf "$(git log -n 1 --pretty='%h %aI' ./LICENSE.txt)" \
   >> ${SOURCE_DIRECTORY}/etc/.rsync-version
 
-printf "[3/5] Notifying application monitors...\n"
-/usr/bin/env curl https://api.rollbar.com/api/1/deploy/ \
-  -F access_token="${ROLLBAR_ACCESS_TOKEN}" \
-  -F environment="${TARGET_ENV}" \
-  -F revision="$(git describe --always --tags)" \
-  -F local_username="$(id -nu ${UID})"
-
-printf "[4/5] Syncing project to target...\n"
+printf "[3/4] Syncing project to target...\n"
 pushd "${SOURCE_DIRECTORY}" >/dev/null
 OIFS=$IFS; IFS=,
 for host in ${TARGET_HOST}; do
@@ -114,7 +106,7 @@ done
 IFS=$OIFS
 popd >/dev/null
 
-printf "[5/5] Post-deploy clean up...\n"
+printf "[4/4] Post-deploy clean up...\n"
 rm ${SOURCE_DIRECTORY}/etc/.rsync-version
 
 printf "Operation complete!\n"

composer.json

@@ -49,7 +49,6 @@
         "ext-mcrypt": "*",
         "ext-memcached": "*",
         "ext-pdo": "*",
-        "php-64bit": ">=5.5.0",
-        "rollbar/rollbar": "^0.18.2"
+        "php-64bit": ">=5.5.0"
     }
 }

composer.lock

@@ -1,3 +1,2 @@
-/.rollbar-token
 /config.phoenix.json
 /config.redux.json

etc/.gitignore

@@ -48,10 +48,5 @@
     "secret": "google-provided-value",
     "sitekey": "google-provided-value",
     "url": "https://www.google.com/recaptcha/api/siteverify"
-  },
-  "rollbar": {
-    "access_token_client": null,
-    "access_token_server": null,
-    "environment": "local"
   }
 }

etc/config.sample.json

@@ -12,73 +12,11 @@
 use \InvalidArgumentException;
 use \PDO;
 use \PDOException;
-use \Rollbar;
 use \RuntimeException;
 
 class Logger extends LoggerMVCLib {
 
-  protected static $event_types       = null;
-  protected static $identified_as     = null;
-  protected static $rollbar_available = false;
-
-  public static function getIdentity() {
-    return self::$identified_as;
-  }
-
-  public static function getIdentityAsRollbar() {
-    $user = self::getIdentity();
-    if (!$user) { return null; }
-    return [
-      'email'    => $user->getEmail(),
-      'id'       => $user->getId(),
-      'username' => $user->getUsername(),
-    ];
-  }
-
-  public static function getTimingHeader($tags = true) {
-    $buffer = parent::getTimingHeader($tags);
-    if (self::$rollbar_available) {
-      ob_start();
-      require('../templates/rollbar.inc.js.phtml');
-      $buffer .= ob_get_clean();
-    }
-    return $buffer;
-  }
-
-  public static function identifyAs(User $user) {
-    self::$identified_as = $user;
-  }
-
-  public static function initialize($override = false) {
-    parent::initialize($override);
-    if (Common::$config->rollbar->access_token_server) {
-      self::$rollbar_available = true;
-
-      $rollbar_handle_exceptions = false;
-      $rollbar_handle_errors     = true;
-      $rollbar_handle_fatal      = true;
-
-      Rollbar::init(
-        [
-          'access_token' => Common::$config->rollbar->access_token_server,
-          'code_version'        => VersionInfo::$version->bnetdocs[0],
-          'environment'         => Common::$config->rollbar->environment,
-          'person_fn'           => 'Logger::getIdentityAsRollbar',
-          'use_error_reporting' => true,
-        ],
-        $rollbar_handle_exceptions,
-        $rollbar_handle_errors,
-        $rollbar_handle_fatal
-      );
-    }
-  }
-
-  public static function logException(Exception $exception) {
-    parent::logException($exception);
-    if (self::$rollbar_available) {
-      Rollbar::report_exception($exception);
-    }
-  }
+  protected static $event_types = null;
 
   public static function &getAllEvents() {
     $event_log = [];

src/libraries/Logger.php

@@ -2,7 +2,6 @@
 
 namespace BNETDocs\Libraries;
 
-use BNETDocs\Libraries\Logger;
 use CarlBennett\MVC\Libraries\Router;
 use CarlBennett\MVC\Libraries\Session as BaseSession;
 
@@ -33,10 +32,6 @@ public static function checkLogin(Router &$router) {
         getenv('HTTP_HOST'), '/'
       );
     }
-    // Notify Logger
-    if (isset($_SESSION['user_id'])) {
-      Logger::identifyAs(new User((int) $_SESSION['user_id']));
-    }
   }
 
 }

src/libraries/Session.php

@@ -47,11 +47,10 @@ function main() {
 
   VersionInfo::$version = VersionInfo::get();
 
-  // This must come after GlobalErrorHandler::createOverrides() because this
-  // will call Rollbar::init() which will create its own error handlers for
-  // Application Performance Monitoring (APM) purposes. This must also come
-  // after assignment of Common::$config because we need the access token for
-  // Rollbar which is present in the config file only.
+  // This must come after GlobalErrorHandler::createOverrides() so that Logger
+  // has a chance to create its own error handlers for Application Performance
+  // Monitoring (APM) purposes. This must also come after assignment of
+  // Common::$config because we may need access tokens from the config.
   Logger::initialize();
 
   Session::initialize(