Merge branch 'v5-doc-updates' of https://github.com/AzureAD/microsoft-authentication-library-for-js into v5-doc-updates

Author: hectormmg

change/@azure-msal-browser-699e9927-8412-43cc-95b8-b75925ac4fc3.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "Refactor BaseClient usage #8119",
+  "packageName": "@azure/msal-browser",
+  "email": "thomas.norling@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@azure-msal-common-edbe6acd-1805-4a96-8617-bb44b12ef72d.json

@@ -0,0 +1,7 @@
+{
+  "type": "minor",
+  "comment": "Refactor BaseClient into Token Protocol #8119",
+  "packageName": "@azure/msal-common",
+  "email": "thomas.norling@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@azure-msal-node-44468730-f46e-4f46-881e-925ecd820788.json

@@ -0,0 +1,7 @@
+{
+  "type": "major",
+  "comment": "Re-wrote HttpClient to use NodeJS's native fetch API (#8137)",
+  "packageName": "@azure/msal-node",
+  "email": "rginsburg@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@azure-msal-node-5c6cce9d-0c23-4fde-8a19-3818c178d139.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "Fixed Minor Type Error in BaseManagedIdentitySource.ts (#8114)",
+  "packageName": "@azure/msal-node",
+  "email": "rginsburg@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@azure-msal-node-826c4371-8293-4ff8-9e43-ca2c15d316f2.json

@@ -0,0 +1,7 @@
+{
+  "type": "major",
+  "comment": "Remove internal classes from public exports #8119",
+  "packageName": "@azure/msal-node",
+  "email": "thomas.norling@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@azure-msal-node-f8ac12ce-f9b6-4e88-b11a-8e5d388d1f92.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "Improved Managed Identity JSDocs (#8115)",
+  "packageName": "@azure/msal-node",
+  "email": "rginsburg@microsoft.com",
+  "dependentChangeType": "patch"
+}

lib/msal-browser/docs/events.md

@@ -18,7 +18,7 @@ You can consult the [EventPayload](https://azuread.github.io/microsoft-authentic
 
 ## How events are emitted in MSAL Browser
 
-Msal browser has a protected function `emitEvent`, and emits events in major APIs. For the list of currently emitted events, see the table below.
+Msal Browser has a protected function `emitEvent`, and emits events in major APIs. For the list of currently emitted events, see the table below.
 
 Here is an example of how MSAL Browser emits an event with a payload, or with an error:
 

lib/msal-browser/src/interaction_handler/InteractionHandler.ts

@@ -107,17 +107,6 @@ export class InteractionHandler {
         // Assign code to request
         this.authCodeRequest.code = authCodeResponse.code;
 
-        // Check for new cloud instance
-        if (authCodeResponse.cloud_instance_host_name) {
-            await invokeAsync(
-                this.authModule.updateAuthority.bind(this.authModule),
-                BrowserPerformanceEvents.UpdateTokenEndpointAuthority,
-                this.logger,
-                this.performanceClient,
-                request.correlationId
-            )(authCodeResponse.cloud_instance_host_name, request.correlationId);
-        }
-
         // Nonce validation not needed when redirect not involved (e.g. hybrid spa, renewing token via rt)
         if (validateNonce) {
             // TODO: Assigning "response nonce" to "request nonce" is confusing. Refactor the function doing validation to accept request nonce directly

lib/msal-browser/src/telemetry/BrowserPerformanceEvents.ts

@@ -139,7 +139,6 @@ export const HandleCodeResponse = "handleCodeResponse";
 export const HandleResponseEar = "handleResponseEar";
 export const HandleResponsePlatformBroker = "handleResponsePlatformBroker";
 export const HandleResponseCode = "handleResponseCode";
-export const UpdateTokenEndpointAuthority = "updateTokenEndpointAuthority";
 
 export const AuthClientAcquireToken = "authClientAcquireToken";
 

lib/msal-browser/test/interaction_handler/InteractionHandler.spec.ts

@@ -23,6 +23,7 @@ import {
     CcsCredential,
     CcsCredentialType,
     StubPerformanceClient,
+    AuthorityFactory,
 } from "@azure/msal-common/browser";
 import {
     Configuration,
@@ -330,87 +331,6 @@ describe("InteractionHandler.ts Unit Tests", () => {
     });
 
     describe("handleCodeResponse()", () => {
-        // TODO: Need to improve these tests
-        it("successfully uses a new authority if cloud_instance_host_name is different", async () => {
-            const idTokenClaims = {
-                ver: "2.0",
-                iss: `${TEST_URIS.DEFAULT_INSTANCE}9188040d-6c67-4c5b-b112-36a304b66dad/v2.0`,
-                sub: "AAAAAAAAAAAAAAAAAAAAAIkzqFVrSaSaFHy782bbtaQ",
-                exp: "1536361411",
-                name: "Abe Lincoln",
-                preferred_username: "AbeLi@microsoft.com",
-                oid: "00000000-0000-0000-66f3-3332eca7ea81",
-                tid: "3338040d-6c67-4c5b-b112-36a304b66dad",
-                nonce: "123523",
-                login_hint: "testLoginHint",
-            };
-            const testCodeResponse: AuthorizationCodePayload = {
-                code: "authcode",
-                nonce: idTokenClaims.nonce,
-                state: TEST_STATE_VALUES.TEST_STATE_REDIRECT,
-                cloud_instance_host_name: "login.windows.net",
-            };
-            const testAccount: AccountInfo = {
-                homeAccountId: TEST_DATA_CLIENT_INFO.TEST_HOME_ACCOUNT_ID,
-                environment: "login.windows.net",
-                tenantId: idTokenClaims.tid,
-                username: idTokenClaims.preferred_username,
-                localAccountId: TEST_DATA_CLIENT_INFO.TEST_LOCAL_ACCOUNT_ID,
-                loginHint: idTokenClaims.login_hint,
-            };
-            const testTokenResponse: AuthenticationResult = {
-                authority: authorityInstance.canonicalAuthority,
-                accessToken: TEST_TOKENS.ACCESS_TOKEN,
-                idToken: TEST_TOKENS.IDTOKEN_V2,
-                fromCache: false,
-                scopes: ["scope1", "scope2"],
-                account: testAccount,
-                correlationId: RANDOM_TEST_GUID,
-                expiresOn: TestTimeUtils.nowDateWithOffset(
-                    TEST_TOKEN_LIFETIMES.DEFAULT_EXPIRES_IN
-                ),
-                idTokenClaims: idTokenClaims,
-                tenantId: idTokenClaims.tid,
-                uniqueId: idTokenClaims.oid,
-                state: "testState",
-                tokenType: Constants.AuthenticationScheme.BEARER,
-            };
-            const updateAuthoritySpy = jest.spyOn(
-                AuthorizationCodeClient.prototype,
-                "updateAuthority"
-            );
-            const acquireTokenSpy = jest
-                .spyOn(AuthorizationCodeClient.prototype, "acquireToken")
-                .mockResolvedValue(testTokenResponse);
-            const interactionHandler = new TestInteractionHandler(
-                authCodeModule,
-                browserStorage
-            );
-            await interactionHandler.initiateAuthRequest("testNavUrl");
-            const tokenResponse = await interactionHandler.handleCodeResponse(
-                testCodeResponse,
-                {
-                    authority: TEST_CONFIG.validAuthority,
-                    scopes: ["User.Read"],
-                    correlationId: TEST_CONFIG.CORRELATION_ID,
-                    redirectUri: "/",
-                    responseMode: "fragment",
-                    nonce: TEST_CONFIG.CORRELATION_ID,
-                    state: TEST_STATE_VALUES.TEST_STATE_REDIRECT,
-                }
-            );
-            expect(updateAuthoritySpy).toHaveBeenCalledWith(
-                testCodeResponse.cloud_instance_host_name,
-                TEST_CONFIG.CORRELATION_ID
-            );
-            expect(tokenResponse).toEqual(testTokenResponse);
-            expect(acquireTokenSpy).toHaveBeenCalledWith(
-                testAuthCodeRequest,
-                testCodeResponse
-            );
-            expect(acquireTokenSpy).not.toThrow();
-        });
-
         it("successfully adds login_hint as CCS credential to auth code request", async () => {
             const idTokenClaims = {
                 ver: "2.0",