Fix tests

Author: neha-bhargava

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/ManagedIdentityParameters.java

@@ -30,8 +30,7 @@ public Set<String> scopes() {
     @Override
     public ClaimsRequest claims() {
         if (claims == null || claims.isEmpty()) {
-            throw new MsalClientException("Claims cannot be null or empty",
-                                         AuthenticationErrorCode.INVALID_JSON);
+            return null;
         }
 
         try {
@@ -108,6 +107,8 @@ public ManagedIdentityParametersBuilder forceRefresh(boolean forceRefresh) {
          * @return this builder instance
          */
         public ManagedIdentityParametersBuilder claims(String claims) {
+            ParameterValidationUtils.validateNotBlank("claims", claims);
+
             this.claims = claims;
             return this;
         }

msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/ManagedIdentityTestDataProvider.java

@@ -118,8 +118,7 @@ public static Stream<Arguments> createDataGetSource() {
     public static Stream<Arguments> createInvalidClaimsData() {
         return Stream.of(
                 Arguments.of("invalid json format"),
-                Arguments.of("{\"access_token\": }"),
-                Arguments.of("")
+                Arguments.of("{\"access_token\": }")
         );
     }
 }

msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/ManagedIdentityTests.java

@@ -738,13 +738,47 @@ void managedIdentity_InvalidClaims(String claimsJson) throws Exception {
 
         ExecutionException ex = assertThrows(ExecutionException.class, future::get);
         assertInstanceOf(MsalClientException.class, ex.getCause());
+
         MsalClientException msalException = (MsalClientException) ex.getCause();
         assertEquals(AuthenticationErrorCode.INVALID_JSON, msalException.errorCode());
 
         // Verify no HTTP requests were made for invalid claims
         verify(httpClientMock, never()).send(any());
     }
 
+    @Test
+    void managedIdentityTest_WithEmptyClaims() throws Exception {
+        IEnvironmentVariables environmentVariables = new EnvironmentVariablesHelper(APP_SERVICE, appServiceEndpoint);
+        ManagedIdentityApplication.setEnvironmentVariables(environmentVariables);
+        DefaultHttpClient httpClientMock = mock(DefaultHttpClient.class);
+
+        miApp = ManagedIdentityApplication
+                .builder(ManagedIdentityId.systemAssigned())
+                .httpClient(httpClientMock)
+                .build();
+
+        try {
+            miApp.acquireTokenForManagedIdentity(
+                    ManagedIdentityParameters.builder(resource)
+                            .claims("")
+                            .build());
+        } catch (Exception exception) {
+            assert(exception instanceof IllegalArgumentException);
+        }
+
+        try {
+            miApp.acquireTokenForManagedIdentity(
+                    ManagedIdentityParameters.builder(resource)
+                            .claims(null)
+                            .build());
+        } catch (Exception exception) {
+            assert(exception instanceof IllegalArgumentException);
+        }
+
+        // Verify no HTTP requests were made for invalid claims
+        verify(httpClientMock, never()).send(any());
+    }
+
     @Nested
     class AzureArc {