address clippy issues (#664)

* address clippy issues

* more clippy updates from 0.1.59

* more clippy updates

* undo lifetime change suggested by clippy

* format based on clippy changes

* allow unnecessary_to_owned from services code

Co-authored-by: Brian Caswell <bcaswell@microsoft.com>

Author: bmc-msft

.github/workflows/build.yml

@@ -80,7 +80,7 @@ jobs:
     name: Services Tests
     runs-on: ubuntu-20.04
     env:
-      RUSTFLAGS: -Dwarnings -Aunreachable-code -Aunused-assignments -Adead-code -Aclippy::new-without-default
+      RUSTFLAGS: -Dwarnings -Aunreachable-code -Aunused-assignments -Adead-code -Aclippy::new-without-default -Aclippy::unnecessary_to_owned
     steps:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1

sdk/core/src/context.rs

@@ -66,8 +66,7 @@ impl Context {
     {
         self.type_map
             .get(&TypeId::of::<E>())
-            .map(|item| item.downcast_ref())
-            .flatten()
+            .and_then(|item| item.downcast_ref())
     }
 
     /// Returns the number of entities in the type map.

sdk/data_cosmos/examples/stored_proc_00.rs

@@ -39,7 +39,7 @@ async fn main() -> Result<(), Box<dyn Error + Send + Sync>> {
         .await?;
 
     println!("Response object:\n{:#?}", ret);
-    println!("Response as JSON:\n{}", ret.payload.to_string());
+    println!("Response as JSON:\n{}", ret.payload);
 
     Ok(())
 }

sdk/data_cosmos/examples/stored_proc_01.rs

@@ -74,7 +74,7 @@ async fn main() -> Result<(), Box<dyn Error + Send + Sync>> {
     );
     println!(
         "Response as JSON:\n{}",
-        execute_stored_procedure_response.payload.to_string()
+        execute_stored_procedure_response.payload
     );
 
     let delete_stored_procedure_response = stored_procedure_client

sdk/security_keyvault/src/key.rs

@@ -468,7 +468,7 @@ impl<'a, T: TokenCredential> KeyClient<'a, T> {
         let mut request_body = Map::new();
         request_body.insert(
             "value".to_owned(),
-            Value::String(base64::encode(decrypt_parameters.ciphertext.to_owned())),
+            Value::String(base64::encode(&decrypt_parameters.ciphertext)),
         );
 
         let algorithm = match decrypt_parameters.decrypt_parameters_encryption {

sdk/storage_blobs/src/delete_snapshot_method.rs

@@ -14,7 +14,7 @@ impl AddAsHeader for DeleteSnapshotsMethod {
     ) -> Result<(), azure_core::HttpHeaderError> {
         request.headers_mut().append(
             azure_core::headers::DELETE_SNAPSHOTS,
-            http::header::HeaderValue::from_str(&self.to_string())?,
+            http::header::HeaderValue::from_str(self.as_ref())?,
         );
 
         Ok(())

sdk/storage_blobs/src/lib.rs

@@ -82,7 +82,7 @@ impl AddAsHeader for RehydratePriority {
     ) -> std::result::Result<(), azure_core::HttpHeaderError> {
         request.headers_mut().append(
             headers::REHYDRATE_PRIORITY,
-            http::header::HeaderValue::from_str(&self.to_string())?,
+            http::header::HeaderValue::from_str(self.as_ref())?,
         );
 
         Ok(())

sdk/storage_queues/examples/queue_create.rs

@@ -53,25 +53,22 @@ async fn main() -> Result<(), Box<dyn Error + Send + Sync>> {
     let response = queue.get_metadata().execute().await?;
     println!("response == {:#?}", response);
 
-    // create two queue stored access policies
-    let mut queue_stored_acess_policies = Vec::new();
-    queue_stored_acess_policies.push(
+    // use two queue stored access policies
+    let queue_stored_acess_policies = vec![
         QueueStoredAccessPolicy::new(
             "first_sap_read_process",
             Utc::now() - Duration::hours(1),
             Utc::now() + Duration::days(1),
         )
         .enable_read()
         .enable_process(),
-    );
-    queue_stored_acess_policies.push(
         QueueStoredAccessPolicy::new(
             "sap_admin",
             Utc::now() - chrono::Duration::hours(1),
             Utc::now() + chrono::Duration::hours(5),
         )
         .enable_all(),
-    );
+    ];
 
     let response = queue
         .set_acl()

services/autorust/codegen/examples/multiple_versions.rs

@@ -11,7 +11,7 @@ pub type Result<T> = std::result::Result<T, Box<dyn std::error::Error>>;
 fn main() -> Result<()> {
     println!("CONTROL PLANE");
     check(&get_mgmt_readmes()?)?;
-    println!("");
+    println!();
     println!("DATA PLANE");
     check(&get_svc_readmes()?)?;
     Ok(())
@@ -32,7 +32,7 @@ fn check(readmes: &[SpecReadme]) -> Result<()> {
                         for version in versions {
                             println!("  {}", version);
                         }
-                        tags = tags + 1;
+                        tags += 1;
                         services.insert(readme.spec());
                     }
                 }
@@ -41,7 +41,7 @@ fn check(readmes: &[SpecReadme]) -> Result<()> {
             }
         }
     }
-    println!("");
+    println!();
     println!("{} tags", tags);
     println!("{} services:", services.len());
     for service in services {

services/autorust/codegen/src/codegen_models.rs

@@ -114,7 +114,7 @@ impl SchemaGen {
     }
 
     fn default(&self) -> Option<&str> {
-        self.schema.common.default.as_ref().map(|v| v.as_str()).flatten()
+        self.schema.common.default.as_ref().and_then(|v| v.as_str())
     }
 
     /// If the type should implement Default