Skip to content

Conversation

@scbedd
Copy link
Member

@scbedd scbedd commented Nov 8, 2025

Followup of #43829

Story on why this PR was necessary:

  1. The thrust of this PR is that we want to ignore package compatibility when building or analyzing. When I passed that to discover_targeted_packages call, we stopped calling apply_compatibility_filter.
  2. Because we don't apply_compatibility_filter, packages that SHOULDNT be included, like our deliberately failing namespace packages are suddenly present that weren't before.
  3. This is the origin of the failing azure-sdk-tools test that stopped me from merging this PR.

I'm pleased we had that, as I definitely think that this needed a small revisit.

This PR:

  1. applies the implicit filter on packages that are usable as an explicit one
  2. The rest of the checks should now only use that already-parsed metadata
  3. We still return the absolute paths to the packages that all consumers of discover_targeted_packages expects.

I'm honestly glad we caught this, as the entire discover_targeted_packages will run faster without constant disk access where none was necesssary.

I've completed a deep comparison of the discovered packages given * + all filter types. The only thing that happens is that stuff that wasn't automatically filtered out during package discovery is now properly filtered. No other differences.

@scbedd scbedd self-assigned this Nov 8, 2025
Copilot AI review requested due to automatic review settings November 8, 2025 01:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the dependency analysis tool to discover all Azure SDK packages regardless of Python version compatibility. The change adds the compatibility_filter=False parameter to the discover_targeted_packages function call in get_lib_deps.

  • Disables Python version compatibility filtering when discovering packages for dependency analysis
  • Ensures all packages in the repository are included in cross-package dependency checks and conflict analysis
  • Aligns with the same pattern used in the build tool

@scbedd scbedd moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 🍔🌭 Nov 10, 2025
…cess + filter out problematic packages before every attempting to use them
Copy link
Member

@l0lawrence l0lawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@scbedd scbedd merged commit b5fbfb9 into Azure:main Nov 12, 2025
20 checks passed
@kurtzeborn kurtzeborn moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 🍔🌭 Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎊 Closed

Development

Successfully merging this pull request may close these issues.

2 participants