Ensure Dependency Analysis properly runs against all packages during analyze
#43892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #43829
Story on why this PR was necessary:
discover_targeted_packagescall, we stopped callingapply_compatibility_filter.apply_compatibility_filter, packages that SHOULDNT be included, like our deliberately failing namespace packages are suddenly present that weren't before.I'm pleased we had that, as I definitely think that this needed a small revisit.
This PR:
discover_targeted_packagesexpects.I'm honestly glad we caught this, as the entire
discover_targeted_packageswill run faster without constant disk access where none was necesssary.I've completed a deep comparison of the discovered packages given
*+ all filter types. The only thing that happens is that stuff that wasn't automatically filtered out during package discovery is now properly filtered. No other differences.