-
Notifications
You must be signed in to change notification settings - Fork 5.6k
refactor(resources): migrate to unified folder structure #38762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
|
The semantic error is reported because there's two APIs that are semantical equivalent. And those APis are not even ARM APIs. those errors are from apiVersion 2016-09-01-preview and 2017-09-01 which has been supersede by the latest preview and stable version. I will add suppression for it. Let me know if @mikeharder or @raych1 has any concerns about it. |
|
This PR is trying to refactor the specification/resources and the new folder structure is showing as the below, where each leaf node here is representing a service (which previously isolated by tags like package-policy-* etc) according to this guideline. Each service will have its own swagger and TypeSpec and tracked the reference by the corresponding independent readme.md files. |
|
I see lots of swagger avocado/lintdiff errors. i know this is just folder restructuring but errors like missing readme.md saying sdk won't be generated makes me nervous. Please take a closer look to ensure we are not breaking stuff here, @zedy-wj, and confirm your findings. |
@sandipsh hi, this is a known issue to the tooling and tracked here, the SDK generation won't have any impact here. |
specification/resources/resource-manager/Microsoft.Resources/links/readme.md
Outdated
Show resolved
Hide resolved
|
@zedy-wj please work with members from each SDK team to fix the SDK generation failure. thanks! |
I have already contacted the relevant SDK team members and am working on addressing the SDK generation failures. |
This PR migrates the resources specification to the new unified folder structure according to Azure folder structure guidelines.
Changes:
resource-manager/Microsoft.Resources/bicepresource-manager/Microsoft.Resources/deploymentStacksreadme.mdfile under theresource-managerpath, the following services are extracted:suppressions.yamlfiles under service folders with new folder structure.tspconfig.yamlwith correct paths.readme.mdBenefits: