Skip to content

Remove default value of Gallery #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove default value of Gallery #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Authentication.Abstractions.Test/AzureEnvironmentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public void TestArmCloudMetadata20220901Init()
else
{
Assert.Equal(AzureEnvironment.TypeBuiltIn, env.Type);
Assert.NotEmpty(env.GalleryUrl);
Assert.Null(env.GalleryUrl);
}
Assert.EndsWith("/", env.ServiceManagementUrl);
Assert.StartsWith(".", env.SqlDatabaseDnsSuffix);
Expand Down
3 changes: 0 additions & 3 deletions src/Authentication.Abstractions/AzureEnvironment.BuiltIn.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ private static AzureEnvironment GetBuiltInAzureCloud()
ActiveDirectoryAuthority = AzureEnvironmentConstants.AzureActiveDirectoryEndpoint,
ActiveDirectoryServiceEndpointResourceId = AzureEnvironmentConstants.AzureServiceEndpoint,
StorageEndpointSuffix = AzureEnvironmentConstants.AzureStorageEndpointSuffix,
GalleryUrl = AzureEnvironmentConstants.GalleryEndpoint,
SqlDatabaseDnsSuffix = AzureEnvironmentConstants.AzureSqlDatabaseDnsSuffix,
GraphUrl = AzureEnvironmentConstants.AzureGraphEndpoint,
TrafficManagerDnsSuffix = AzureEnvironmentConstants.AzureTrafficManagerDnsSuffix,
Expand Down Expand Up @@ -80,7 +79,6 @@ private static AzureEnvironment GetBuiltInChinaAzureCloud()
ActiveDirectoryAuthority = AzureEnvironmentConstants.ChinaActiveDirectoryEndpoint,
ActiveDirectoryServiceEndpointResourceId = AzureEnvironmentConstants.ChinaServiceEndpoint,
StorageEndpointSuffix = AzureEnvironmentConstants.ChinaStorageEndpointSuffix,
GalleryUrl = AzureEnvironmentConstants.GalleryEndpoint,
SqlDatabaseDnsSuffix = AzureEnvironmentConstants.ChinaSqlDatabaseDnsSuffix,
GraphUrl = AzureEnvironmentConstants.ChinaGraphEndpoint,
TrafficManagerDnsSuffix = AzureEnvironmentConstants.ChinaTrafficManagerDnsSuffix,
Expand Down Expand Up @@ -120,7 +118,6 @@ private static AzureEnvironment GetBuiltInUSGovernmentCloud()
ActiveDirectoryAuthority = AzureEnvironmentConstants.USGovernmentActiveDirectoryEndpoint,
ActiveDirectoryServiceEndpointResourceId = AzureEnvironmentConstants.USGovernmentServiceEndpoint,
StorageEndpointSuffix = AzureEnvironmentConstants.USGovernmentStorageEndpointSuffix,
GalleryUrl = AzureEnvironmentConstants.GalleryEndpoint,
SqlDatabaseDnsSuffix = AzureEnvironmentConstants.USGovernmentSqlDatabaseDnsSuffix,
GraphUrl = AzureEnvironmentConstants.USGovernmentGraphEndpoint,
TrafficManagerDnsSuffix = AzureEnvironmentConstants.USGovernmentTrafficManagerDnsSuffix,
Expand Down
3 changes: 3 additions & 0 deletions src/Authentication.Abstractions/AzureEnvironmentConstants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,11 @@ public static class AzureEnvironmentConstants
/// <summary>
/// Template gallery endpoints
/// </summary>
[Obsolete("Gallery endpoint is removed from ARM metadata.")]
public const string GalleryEndpoint = "https://gallery.azure.com/";
[Obsolete("Gallery endpoint is removed from ARM metadata.")]
public const string ChinaGalleryEndpoint = "https://gallery.chinacloudapi.cn/";
[Obsolete("Gallery endpoint is removed from ARM metadata.")]
public const string USGovernmentGalleryEndpoint = "https://gallery.usgovcloudapi.net/";
[Obsolete("Microsoft Cloud Germany was closed on October 29th, 2021.")]
public const string GermanGalleryEndpoint = "https://gallery.cloudapi.de/";
Expand Down