Skip to content

[Az.DevCenter] Add data plane endpoint #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Az.DevCenter] Add data plane endpoint #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a98241
Add DevCenter data plane endpoint
am-lim Apr 20, 2023
dea0121
fix endpoint
am-lim May 4, 2023
0ee4224
Merge pull request #1 from am-lim/amlim/addDevCenterDataplaneEndpoint
am-lim May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Authentication.Abstractions/AzureEnvironment.BuiltIn.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,9 @@ private static void SetExtendedProperties(IDictionary<string, AzureEnvironment>
azureEnvironments[EnvironmentName.AzureCloud].SetProperty(ExtendedEndpoint.AzurePurviewEndpointResourceId, AzureEnvironmentConstants.AzurePurviewEndpointResourceId);
azureEnvironments[EnvironmentName.AzureCloud].SetProperty(ExtendedEndpoint.AzureAppConfigurationEndpointSuffix, AzureEnvironmentConstants.AzureAppConfigurationEndpointSuffix);
azureEnvironments[EnvironmentName.AzureCloud].SetProperty(ExtendedEndpoint.AzureAppConfigurationEndpointResourceId, AzureEnvironmentConstants.AzureAppConfigurationEndpointResourceId);
azureEnvironments[EnvironmentName.AzureCloud].SetProperty(ExtendedEndpoint.ContainerRegistryEndpointResourceId, AzureEnvironmentConstants.AzureContainerRegistryEndpointResourceId);
azureEnvironments[EnvironmentName.AzureCloud].SetProperty(ExtendedEndpoint.ContainerRegistryEndpointResourceId, AzureEnvironmentConstants.AzureContainerRegistryEndpointResourceId);
azureEnvironments[EnvironmentName.AzureCloud].SetProperty(ExtendedEndpoint.AzureDevCenterEndpointSuffix, AzureEnvironmentConstants.AzureDevCenterEndpointSuffix);
azureEnvironments[EnvironmentName.AzureCloud].SetProperty(ExtendedEndpoint.AzureDevCenterEndpointResourceId, AzureEnvironmentConstants.AzureDevCenterEndpointResourceId);
}

if (azureEnvironments.ContainsKey(EnvironmentName.AzureChinaCloud))
Expand Down
4 changes: 3 additions & 1 deletion src/Authentication.Abstractions/AzureEnvironment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,9 @@ public static class ExtendedEndpoint
AzurePurviewEndpointResourceId = "AzurePurviewEndpointResourceId",
AzureAppConfigurationEndpointSuffix = "AzureAppConfigurationEndpointSuffix",
AzureAppConfigurationEndpointResourceId = "AzureAppConfigurationEndpointResourceId",
ContainerRegistryEndpointResourceId = "ContainerRegistryEndpointResourceId";
ContainerRegistryEndpointResourceId = "ContainerRegistryEndpointResourceId",
AzureDevCenterEndpointSuffix = "AzureDevCenterEndpointSuffix",
AzureDevCenterEndpointResourceId = "AzureDevCenterEndpointResourceId";
}
}
}
9 changes: 9 additions & 0 deletions src/Authentication.Abstractions/AzureEnvironmentConstants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,15 @@ public static class AzureEnvironmentConstants
        public const string USGovernmentContainerRegistryEndpointResourceId = "https://management.usgovcloudapi.net";
        public const string AzureContainerRegistryEndpointResourceId = "https://management.azure.com";

/// <summary>
/// The domain name suffix for Azure DevCenter
/// </summary>
public const string AzureDevCenterEndpointSuffix = "devcenter.azure.com";

/// <summary>
/// The token audience for authorizing DevCenter Service requests
/// </summary>
public const string AzureDevCenterEndpointResourceId = "https://devcenter.azure.com";

}
}
14 changes: 12 additions & 2 deletions src/Authentication.Abstractions/Extensions/AzureEnvironmentExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,13 @@ public static void SetEndpoint(this IAzureEnvironment environment, string endpoi
break;
case AzureEnvironment.ExtendedEndpoint.ContainerRegistryEndpointResourceId:
environment.SetProperty(AzureEnvironment.ExtendedEndpoint.ContainerRegistryEndpointResourceId, propertyValue);
break;
break;
case AzureEnvironment.ExtendedEndpoint.AzureDevCenterEndpointSuffix:
environment.SetProperty(AzureEnvironment.ExtendedEndpoint.AzureDevCenterEndpointSuffix, propertyValue);
break;
case AzureEnvironment.ExtendedEndpoint.AzureDevCenterEndpointResourceId:
environment.SetProperty(AzureEnvironment.ExtendedEndpoint.AzureDevCenterEndpointResourceId, propertyValue);
break;
}
}
}
Expand Down Expand Up @@ -385,7 +391,11 @@ public static string GetTokenAudience(this IAzureEnvironment environment, string
break;
case AzureEnvironment.ExtendedEndpoint.ContainerRegistryEndpointResourceId:
resource = AzureEnvironment.ExtendedEndpoint.ContainerRegistryEndpointResourceId;
break;
break;
case AzureEnvironment.ExtendedEndpoint.AzureDevCenterEndpointSuffix:
case AzureEnvironment.ExtendedEndpoint.AzureDevCenterEndpointResourceId:
resource = AzureEnvironment.ExtendedEndpoint.AzureDevCenterEndpointResourceId;
break;
default:
resource = AzureEnvironment.Endpoint.ActiveDirectoryServiceEndpointResourceId;
break;
Expand Down