Acr endpoints fix debug message filter (#226)

* add ACR domain suffix

* fix

* provide parameter to accepet list of regex filter

* remove redundant constructor

* correct variable name

* move debugging filter to AzurePSCmdlet

* Update AzurePSCmdlet.cs

remove redundant line

* Update AzurePSCmdlet.cs

remove unnecessary decorator

* Update AzurePSCmdlet.cs

add comments

* mark default matcher as static readonly

* fix

* bug fix

* apply matchers to serviceclient interceptor

* add containerregistry to endpoint

* remove white space

Author: VeryEarly

src/Authentication.Abstractions/AzureEnvironment.cs

@@ -627,6 +627,7 @@ public static class Endpoint
                 AzureDataLakeAnalyticsCatalogAndJobEndpointSuffix = "AzureDataLakeAnalyticsCatalogAndJobEndpointSuffix",
                 AzureDataLakeStoreFileSystemEndpointSuffix = "AzureDataLakeStoreFileSystemEndpointSuffix",
                 DataLakeEndpointResourceId = "DataLakeEndpointResourceId",
+                ContainerRegistryEndpointSuffix = "ContainerRegistryEndpointSuffix",
                 BatchEndpointResourceId = "BatchEndpointResourceId";
         }
 

src/Common/AzurePSCmdlet.cs

@@ -48,8 +48,8 @@ public abstract class AzurePSCmdlet : PSCmdlet, IDisposable
         private object lockObject = new object();
         private AzurePSDataCollectionProfile _cachedProfile = null;
 
-        private IList<Regex> _matchers = new List<Regex>();
-        private static readonly Regex _defaultMatcher = new Regex("(\\s*\"refresh_token\"\\s*:\\s*)\"[^\"]+\"");
+        protected IList<Regex> _matchers { get;  private set; }  = new List<Regex>();
+        private static readonly Regex _defaultMatcher = new Regex("(\\s*\"access_token\"\\s*:\\s*)\"[^\"]+\"");
 
         protected AzurePSDataCollectionProfile _dataCollectionProfile
         {

src/ResourceManager/Version2016_09_01/AzureRMCmdlet.cs

@@ -310,7 +310,7 @@ protected override void SetupDebuggingTraces()
             ServiceClientTracing.IsEnabled = true;
             base.SetupDebuggingTraces();
             _serviceClientTracingInterceptor = _serviceClientTracingInterceptor
-                ?? new ServiceClientTracingInterceptor(DebugMessages);
+                ?? new ServiceClientTracingInterceptor(DebugMessages, _matchers);
             ServiceClientTracing.AddTracingInterceptor(_serviceClientTracingInterceptor);
         }
 

src/ResourceManager/Version2016_09_01/ServiceClientTracingInterceptor.cs

@@ -18,18 +18,22 @@
 using System;
 using System.Collections.Concurrent;
 using System.Collections.Generic;
+using System.Text.RegularExpressions;
 
 namespace Microsoft.Azure.Commands.ResourceManager.Common
 {
     public class ServiceClientTracingInterceptor : IServiceClientTracingInterceptor
     {
-        public ServiceClientTracingInterceptor(ConcurrentQueue<string> queue)
+        public ServiceClientTracingInterceptor(ConcurrentQueue<string> queue, IList<Regex> matchers = null)
         {
             MessageQueue = queue;
+            Matchers = matchers;
         }
 
         public ConcurrentQueue<string> MessageQueue { get; private set; }
 
+        private IList<Regex> Matchers { get; set; }
+
         public void Configuration(string source, string name, string value)
         {
             // Ignore 
@@ -52,13 +56,13 @@ public void Information(string message)
 
         public void ReceiveResponse(string invocationId, System.Net.Http.HttpResponseMessage response)
         {
-            string responseAsString = response == null ? string.Empty : GeneralUtilities.GetLog(response);
+            string responseAsString = response == null ? string.Empty : GeneralUtilities.GetLog(response, Matchers);
             MessageQueue.CheckAndEnqueue(responseAsString);
         }
 
         public void SendRequest(string invocationId, System.Net.Http.HttpRequestMessage request)
         {
-            string requestAsString = request == null ? string.Empty : GeneralUtilities.GetLog(request);
+            string requestAsString = request == null ? string.Empty : GeneralUtilities.GetLog(request, Matchers);
             MessageQueue.CheckAndEnqueue(requestAsString);
         }