Fix access error when subscripiton has no Tags property (#277)

msJinLei · web-flow · commit 92c73a28d304 · 2021-07-13T12:35:44.000+08:00
Azure/azure-powershell#15425
diff --git a/src/Authentication.Abstractions/Extensions/AzureSubscriptionExtensions.cs b/src/Authentication.Abstractions/Extensions/AzureSubscriptionExtensions.cs
@@ -200,7 +200,8 @@ public static void SetSubscriptionPolicies(this IAzureSubscription subscription,
         /// <returns>The tags of the subscription</returns>
         public static Dictionary<string,string> GetTags(this IAzureSubscription subscription)
         {
-            return JsonConvert.DeserializeObject<Dictionary<string,string>>(subscription.GetProperty(AzureSubscription.Property.Tags));
+            var tags = subscription.GetProperty(AzureSubscription.Property.Tags);
+            return string.IsNullOrEmpty(tags) ? null : JsonConvert.DeserializeObject<Dictionary<string,string>>(tags);
         }
 
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,8 @@ public static void SetSubscriptionPolicies(this IAzureSubscription subscription,`
`200`	`200`	`/// <returns>The tags of the subscription</returns>`
`201`	`201`	`public static Dictionary<string,string> GetTags(this IAzureSubscription subscription)`
`202`	`202`	`{`
`203`		`- return JsonConvert.DeserializeObject<Dictionary<string,string>>(subscription.GetProperty(AzureSubscription.Property.Tags));`
	`203`	`+ var tags = subscription.GetProperty(AzureSubscription.Property.Tags);`
	`204`	`+ return string.IsNullOrEmpty(tags) ? null : JsonConvert.DeserializeObject<Dictionary<string,string>>(tags);`
`204`	`205`	`}`
`205`	`206`
`206`	`207`	`/// <summary>`