Fix HasDefault syntax (#1039)

* fix syntax and add test

* update test to catch errors

* undo copy paste error

* undo changes to AddProductWithIdentity_MissingPrimaryColumn

* ad comment and update product defnition for other langs

* use Integer for nullable int in Java

* missed nullable int

* csx miss

Author: MaddyDev

samples/samples-csharp/Common/Product.cs

@@ -5,7 +5,7 @@ namespace Microsoft.Azure.WebJobs.Extensions.Sql.Samples.Common
 {
     public class Product
     {
-        public int ProductId { get; set; }
+        public int? ProductId { get; set; }
 
         public string Name { get; set; }
 

samples/samples-csx/Common/product.csx

@@ -3,7 +3,7 @@
 
 public class Product
 {
-    public int ProductId { get; set; }
+    public int? ProductId { get; set; }
 
     public string Name { get; set; }
 

samples/samples-java/src/main/java/com/function/Common/Product.java

@@ -7,7 +7,7 @@
 package com.function.Common;
 
 public class Product {
-    private int ProductId;
+    private Integer ProductId;
     private String Name;
     private int Cost;
 

samples/samples-outofproc/Product.cs

@@ -6,7 +6,7 @@ namespace Microsoft.Azure.WebJobs.Extensions.Sql.SamplesOutOfProc.Common
 {
     public class Product
     {
-        public int ProductId { get; set; }
+        public int? ProductId { get; set; }
 
         public string Name { get; set; }
 

src/SqlAsyncCollector.cs

@@ -474,7 +474,7 @@ public static string GetPrimaryKeysQuery(SqlObject table)
                         ccu.{ColumnName},
                         c.is_identity,
                         case
-                            when isc.COLUMN_DEFAULT = NULL then 'false'
+                            when isc.COLUMN_DEFAULT IS NULL then 'false'
                             else 'true'
                         end as {HasDefault}
                     FROM

test-outofproc/Product.cs

@@ -8,7 +8,7 @@ namespace DotnetIsolatedTests.Common
 {
     public class Product
     {
-        public int ProductId { get; set; }
+        public int? ProductId { get; set; }
 
         public string Name { get; set; }
 

test/Integration/SqlOutputBindingIntegrationTests.cs

@@ -352,6 +352,8 @@ public async Task AddProductWithDefaultPKTest(SupportedLanguages lang)
             await this.SendOutputPostRequest("addproductwithdefaultpk", Utils.JsonSerializeObject(product), TestUtils.GetPort(lang));
             await this.SendOutputPostRequest("addproductwithdefaultpk", Utils.JsonSerializeObject(product), TestUtils.GetPort(lang));
             Assert.Equal(2, this.ExecuteScalar("SELECT COUNT(*) FROM dbo.ProductsWithDefaultPK"));
+            // Should throw error when there is no default PK and the primary key is missing from the user object.
+            Assert.Throws<AggregateException>(() => this.SendOutputPostRequest("addproduct", Utils.JsonSerializeObject(product), TestUtils.GetPort(lang)).Wait());
         }
 
         /// <summary>

test/Integration/SqlTriggerBindingIntegrationTestBase.cs

@@ -100,10 +100,10 @@ void MonitorOutputData(object sender, DataReceivedEventArgs e)
                             Assert.Equal(operation, change.Operation); // Expected change operation
                             Product product = change.Item;
                             Assert.NotNull(product); // Product deserialized correctly
-                            Assert.Contains(product.ProductId, expectedIds); // We haven't seen this product ID yet, and it's one we expected to see
-                            expectedIds.Remove(product.ProductId);
-                            Assert.Equal(getName(product.ProductId), product.Name); // The product has the expected name
-                            Assert.Equal(getCost(product.ProductId), product.Cost); // The product has the expected cost
+                            Assert.Contains(product.ProductId.Value, expectedIds); // We haven't seen this product ID yet, and it's one we expected to see
+                            expectedIds.Remove(product.ProductId.Value);
+                            Assert.Equal(getName(product.ProductId.Value), product.Name); // The product has the expected name
+                            Assert.Equal(getCost(product.ProductId.Value), product.Cost); // The product has the expected cost
                         }
                     }
                     catch (Exception ex)

test/Integration/test-csx/Common/Product.csx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License. See License.txt in the project root for license information.
 public class Product
 {
-    public int ProductId { get; set; }
+    public int? ProductId { get; set; }
 
     public string Name { get; set; }