[backport] v1.6 ci: [CNS] Overlay Expansion Subnet Update Job Bug Fix #4103 #4114
+143
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR backports a bug fix for the CNS Overlay Expansion Subnet Update Job to v1.6. The fix enables CNS to accept network container subnet expansions by validating whether a new subnet is a superset of the existing subnet, rather than failing when any subnet change is detected.
Key Changes:
- Added subnet superset validation logic to allow overlay subnet expansion scenarios
- Enhanced test coverage with multiple test cases for both valid and invalid subnet changes
- Refactored tests to use table-driven test patterns
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| cns/restserver/internalapi.go | Added conditional logic to validate if new subnet is a superset of existing subnet before rejecting NC updates |
| cns/restserver/internalapi_test.go | Converted single test case to table-driven tests and added new test function for valid subnet expansion scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
thatmattlong
approved these changes
Nov 12, 2025
Any commits made after this event will not be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Backporting subnet overlay expansion to v1.6
Issue Fixed:
Requirements:
Notes: