Move docker image publishing into release pipeline (#1602)

* remove push

* version

Author: akshaysngupta

.pipelines/nightly-build.yml

@@ -33,15 +33,9 @@ steps:
       echo '##vso[task.prependpath]$(GOROOT)/bin'
     displayName: "Set up the Go workspace"
 
-  - task: Docker@2
-    displayName: Login to ACR
-    inputs:
-      command: login
-      containerRegistry: "AGIC Registry"
-
   - script: |
       docker buildx create --use
-      make build-image-multi-arch BUILD_TAG=$(build.buildid) PUSH_IMAGE=true
+      make build-image-multi-arch BUILD_TAG=$(build.buildid)
     workingDirectory: "$(modulePath)"
     displayName: "Build nightly image"
 

.pipelines/release-build.yml

@@ -28,15 +28,9 @@ steps:
       echo '##vso[task.prependpath]$(GOROOT)/bin'
     displayName: "Set up the Go workspace"
 
-  - task: Docker@2
-    displayName: Login to ACR
-    inputs:
-      command: login
-      containerRegistry: "AGIC Registry"
-
   - script: |
       docker buildx create --use
-      make build-image-multi-arch RELEASE_IMAGE=true PUSH_IMAGE=true
+      make build-image-multi-arch RELEASE_IMAGE=true
     workingDirectory: "$(modulePath)"
     displayName: "Build release image"
 

Makefile

@@ -21,7 +21,7 @@ REPO ?= appgwreg.azurecr.io
 IMAGE_NAME = public/azure-application-gateway/kubernetes-ingress-staging
 IMAGE = ${REPO}/${IMAGE_NAME}
 
-IMAGE_RESULT_FLAG = --output=type=oci,dest=$(shell pwd)/image/ingress-agic-$(VERSION).tar
+IMAGE_RESULT_FLAG = --output=type=oci,dest=$(shell pwd)/image/ingress-agic-$(BUILD_TAG).tar
 ifeq ($(PUSH_IMAGE), true)
 	IMAGE_RESULT_FLAG = --push
 endif