Skip to content

Commit d852aae

Browse files
authored
Fixed tooltip button position (#2724)
Fixed scrolling on subscription rename/cancel
1 parent 38a7281 commit d852aae

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

src/components/apis/details-of-api/ko/detailsOfApiEditor.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
<div class="label-group">
44
<label for="hyperlink" class="form-label">
55
Link to API changelog page
6+
<button class="btn btn-info" type="button" title="Help" aria-label="Help"
7+
data-bind="tooltip: 'A link to be navigated on click.'"></button>
68
</label>
7-
<button class="btn btn-info" type="button" title="Help" aria-label="Help"
8-
data-bind="tooltip: 'A link to be navigated on click.'"></button>
99
</div>
1010
<div class="input-group">
1111
<input id="hyperlink" type="text" class="form-control" disabled data-bind="value: hyperlinkTitle" />

src/components/apis/list-of-apis/ko/listOfApisEditor.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@
2424
<div class="label-group">
2525
<label for="hyperlink" class="form-label">
2626
Link to API details page
27+
<button class="btn btn-info" type="button" aria-hidden="true" role="tooltip"
28+
aria-label="A link to be navigated on click" data-bind="tooltip: 'A link to be navigated on click.'">
29+
</button>
2730
</label>
28-
<button class="btn btn-info" type="button" aria-hidden="true" role="tooltip"
29-
aria-label="A link to be navigated on click" data-bind="tooltip: 'A link to be navigated on click.'">
30-
</button>
3131
</div>
3232
<div class="input-group">
3333
<input type="text" id="hyperlink" class="form-control" disabled data-bind="value: hyperlinkTitle" />

src/components/users/validation-summary/ko/runtime/validation-summary.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ export class ValidationSummary {
4040
this.errorMsgs(errorSum);
4141
if (this.errorMsgs().length > 0) {
4242
this.hasErrors(true);
43+
document.getElementsByTagName(selector)[0]?.scrollIntoView();
4344
} else {
4445
this.hasErrors(false);
4546
}
4647

47-
document.getElementsByTagName(selector)[0]?.scrollIntoView();
4848
}
4949
}

src/themes/designer/styles/forms.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@
2222
margin-bottom: 15px;
2323
}
2424

25+
label.form-label {
26+
position: relative;
27+
}
28+
2529
&.form-group-collapsible {
2630
& > .form-label {
2731
position: unset;

0 commit comments

Comments
 (0)