Used naming cinvention with dash (#2414)

Author: malincrist

src/components/apis/api-products/apiProductsModelBinder.ts

@@ -19,7 +19,7 @@ export class ApiProductsModelBinder implements IModelBinder<ApiProductsModel> {
 
     public modelToContract(model: ApiProductsModel): ApiProductsContract {
         const contract: ApiProductsContract = {
-            type: "apiProducts",
+            type: "api-products",
             itemStyleView: model.layout,
             detailsPageHyperlink: model.detailsPageHyperlink
             ? {

src/components/apis/api-products/ko/apiProducts.module.ts

@@ -14,28 +14,16 @@ export class ApiProductsPublishModule implements IInjectorModule {
 
         const widgetService = injector.resolve<IWidgetService>("widgetService");
 
-        widgetService.registerWidget("apiProducts", {
+        const apiProductsWidget = {
             modelDefinition: ApiProductsModel,
             componentBinder: KnockoutComponentBinder,
             componentDefinition: ApiProductsViewModel,
             modelBinder: ApiProductsModelBinder,
             viewModelBinder: ApiProductsViewModelBinder
-        });
+        };
 
-        widgetService.registerWidget("apiProductsDropdown", {
-            modelDefinition: ApiProductsModel,
-            componentBinder: KnockoutComponentBinder,
-            componentDefinition: ApiProductsViewModel,
-            modelBinder: ApiProductsModelBinder,
-            viewModelBinder: ApiProductsViewModelBinder
-        });
-
-        widgetService.registerWidget("apiProductsTiles", {
-            modelDefinition: ApiProductsModel,
-            componentBinder: KnockoutComponentBinder,
-            componentDefinition: ApiProductsViewModel,
-            modelBinder: ApiProductsModelBinder,
-            viewModelBinder: ApiProductsViewModelBinder
-        });
+        widgetService.registerWidget("api-products", apiProductsWidget);
+        widgetService.registerWidget("api-products-dropdown", apiProductsWidget);
+        widgetService.registerWidget("api-products-tiles", apiProductsWidget);
     }
 }

src/components/apis/api-products/ko/apiProductsEditor.module.ts

@@ -19,13 +19,15 @@ export class ApiProductsDesignModule implements IInjectorModule {
 
         const widgetService = injector.resolve<IWidgetService>("widgetService");
 
-        widgetService.registerWidget("apiProducts", {
+        const apiProductsWidget = {
             modelDefinition: ApiProductsModel,
             componentBinder: KnockoutComponentBinder,
             componentDefinition: ApiProductsViewModel,
             modelBinder: ApiProductsModelBinder,
             viewModelBinder: ApiProductsViewModelBinder
-        });
+        };
+
+        widgetService.registerWidget("api-products", apiProductsWidget);
 
         widgetService.registerWidgetEditor("apiProducts", {
             displayName: "API: Products",
@@ -36,15 +38,9 @@ export class ApiProductsDesignModule implements IInjectorModule {
             handlerComponent: ApiProductsHandlers
         });
 
-        widgetService.registerWidget("apiProductsDropdown", {
-            modelDefinition: ApiProductsModel,
-            componentBinder: KnockoutComponentBinder,
-            componentDefinition: ApiProductsViewModel,
-            modelBinder: ApiProductsModelBinder,
-            viewModelBinder: ApiProductsViewModelBinder
-        });
+        widgetService.registerWidget("api-products-dropdown", apiProductsWidget);
 
-        widgetService.registerWidgetEditor("apiProductsDropdown", {
+        widgetService.registerWidgetEditor("api-products-dropdown", {
             displayName: "API: Products (dropdown)",
             category: "APIs",
             iconClass: "widget-icon widget-icon-api-management",
@@ -53,15 +49,9 @@ export class ApiProductsDesignModule implements IInjectorModule {
             handlerComponent: ApiProductsDropdownHandlers
         });
 
-        widgetService.registerWidget("apiProductsTiles", {
-            modelDefinition: ApiProductsModel,
-            componentBinder: KnockoutComponentBinder,
-            componentDefinition: ApiProductsViewModel,
-            modelBinder: ApiProductsModelBinder,
-            viewModelBinder: ApiProductsViewModelBinder
-        });
+        widgetService.registerWidget("api-products-tiles", apiProductsWidget);
 
-        widgetService.registerWidgetEditor("apiProductsTiles", {
+        widgetService.registerWidgetEditor("api-products-tiles", {
             displayName: "API: Products (tiles)",
             category: "APIs",
             iconClass: "widget-icon widget-icon-api-management",