fix eslint error

Author: zhiyuanliang-ms

eslint.config.mjs

@@ -0,0 +1,78 @@
+import { defineConfig, globalIgnores } from "eslint/config";
+import typescriptEslint from "@typescript-eslint/eslint-plugin";
+import globals from "globals";
+import tsParser from "@typescript-eslint/parser";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import js from "@eslint/js";
+import { FlatCompat } from "@eslint/eslintrc";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+    baseDirectory: __dirname,
+    recommendedConfig: js.configs.recommended,
+    allConfig: js.configs.all
+});
+
+export default defineConfig([globalIgnores([
+    "node_modules/**",
+    "dist/**",
+    "dist-esm/**",
+    "types/**",
+    "*.min.js",
+    "coverage/**"
+]), {
+    extends: compat.extends("eslint:recommended", "plugin:@typescript-eslint/recommended"),
+
+    plugins: {
+        "@typescript-eslint": typescriptEslint,
+    },
+
+    languageOptions: {
+        globals: {
+            ...globals.browser,
+            ...globals.commonjs,
+            ...globals.node,
+            ...globals.mocha,
+        },
+
+        parser: tsParser,
+        ecmaVersion: "latest",
+        sourceType: "commonjs",
+    },
+
+    rules: {
+        "keyword-spacing": ["error", {
+            before: true,
+            after: true,
+        }],
+
+        quotes: ["error", "double", {
+            avoidEscape: true,
+        }],
+
+        "@typescript-eslint/no-explicit-any": "off",
+        "eol-last": ["error", "always"],
+        "no-trailing-spaces": "error",
+        "space-before-blocks": ["error", "always"],
+        "no-multi-spaces": "error",
+
+        "no-multiple-empty-lines": ["error", {
+            max: 1,
+        }],
+
+        semi: ["error", "always"],
+    },
+}, {
+    files: ["**/.eslintrc.{js,cjs}"],
+
+    languageOptions: {
+        globals: {
+            ...globals.node,
+        },
+
+        ecmaVersion: 5,
+        sourceType: "commonjs",
+    },
+}]);

examples/console-app/refresh.mjs

@@ -32,7 +32,6 @@ const settings = await load(connectionString, {
 
 console.log("Using Azure portal or CLI, update the `app.settings.message` value, and then update the `app.settings.sentinel` value in your App Configuration store.");
 
-// eslint-disable-next-line no-constant-condition
 while (true) {
     // this is a blocking call and you can remove await to make the refresh operation asynchronous
     await settings.refresh();

package-lock.json

@@ -4,6 +4,7 @@
   "description": "The JavaScript configuration provider for Azure App Configuration",
   "main": "dist/index.js",
   "module": "./dist-esm/index.js",
+  "type": "module",
   "types": "types/index.d.ts",
   "files": [
     "dist/**/*.js",
@@ -23,9 +24,9 @@
     "build-test": "tsc -p ./tsconfig.test.json",
     "clean": "rimraf dist dist-esm out types",
     "dev": "rollup --config --watch",
-    "lint": "eslint src/ test/ examples/ --ext .js,.ts,.mjs,.cjs",
-    "fix-lint": "eslint src/ test/ examples/ --fix --ext .js,.ts,.mjs,.cjs",
-    "test": "mocha out/test/*.test.{js,cjs,mjs} --parallel"
+    "lint": "eslint src/ test/ examples/ --ext .js,.ts,.mjs",
+    "fix-lint": "eslint src/ test/ examples/ --fix --ext .js,.ts,.mjs",
+    "test": "mocha out/test/*.test.js --parallel"
   },
   "repository": {
     "type": "git",
@@ -34,6 +35,8 @@
   "license": "MIT",
   "devDependencies": {
     "@rollup/plugin-typescript": "^11.1.6",
+    "@types/chai": "^5.2.2",
+    "@types/chai-as-promised": "8.0.2",
     "@types/mocha": "^10.0.10",
     "@types/node": "^22.18.0",
     "@types/sinon": "^17.0.4",

package.json

@@ -424,7 +424,7 @@ export class AzureAppConfigurationImpl implements AzureAppConfiguration {
                 // get feature management package version
                 const fmPackage = await import(FM_PACKAGE_NAME);
                 this.#fmVersion = fmPackage?.VERSION;
-            } catch (error) {
+            } catch {
                 // ignore the error
             }
         }

src/appConfigurationImpl.ts

@@ -42,7 +42,7 @@ import {
     DELIMITER,
     AI_CONFIGURATION_TAG,
     AI_CHAT_COMPLETION_CONFIGURATION_TAG
-} from "./constants";
+} from "./constants.js";
 
 export interface RequestTracingOptions {
     enabled: boolean;

src/requestTracing/utils.ts

@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
+/* eslint-disable @typescript-eslint/no-unused-expressions */
 import * as chai from "chai";
 import chaiAsPromised from "chai-as-promised";
 chai.use(chaiAsPromised);
@@ -130,3 +131,4 @@ describe("custom client options", function () {
         expect(countPolicy.count).eq(3);
     });
 });
+/* eslint-enable @typescript-eslint/no-unused-expressions */

test/clientOptions.test.ts

@@ -1,4 +1,4 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-export { load } from "../src";
+export { load } from "../src/index.js";

test/exportedApi.ts

@@ -1,13 +1,14 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
+/* eslint-disable @typescript-eslint/no-unused-expressions */
 import * as chai from "chai";
 import chaiAsPromised from "chai-as-promised";
 chai.use(chaiAsPromised);
 const expect = chai.expect;
-import { load } from "./exportedApi";
-import { MAX_TIME_OUT, createMockedConnectionString, createMockedFeatureFlag, createMockedKeyValue, mockConfigurationManagerGetClients, restoreMocks } from "./utils/testHelper";
-import { getValidDomain, isValidEndpoint } from "../src/configurationClientManager";
+import { load } from "./exportedApi.js";
+import { MAX_TIME_OUT, createMockedConnectionString, createMockedFeatureFlag, createMockedKeyValue, mockConfigurationManagerGetClients, restoreMocks } from "./utils/testHelper.js";
+import { getValidDomain, isValidEndpoint } from "../src/configurationClientManager.js";
 
 const mockedKVs = [{
     key: "app.settings.fontColor",
@@ -102,3 +103,4 @@ describe("failover", function () {
         expect(isValidEndpoint("foobar.appconfig.azure.com", validDomain4)).to.be.false;
     });
 });
+/* eslint-enable @typescript-eslint/no-unused-expressions */

test/failover.test.ts

@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
+/* eslint-disable @typescript-eslint/no-unused-expressions */
 import * as chai from "chai";
 import chaiAsPromised from "chai-as-promised";
 import { featureFlagContentType } from "@azure/app-configuration";
@@ -434,3 +435,4 @@ describe("feature flags", function () {
         restoreMocks();
     });
 });
+/* eslint-enable @typescript-eslint/no-unused-expressions */