add more testcases

Author: zhiyuanliang-ms

package.json

@@ -25,7 +25,7 @@
     "dev": "rollup --config --watch",
     "lint": "eslint src/ test/",
     "fix-lint": "eslint src/ test/ --fix",
-    "test": "mocha out/test/*.test.{js,cjs,mjs} --parallel"
+    "test": "mocha out/test/featureFlag.test.{js,cjs,mjs} --parallel"
   },
   "repository": {
     "type": "git",

src/AzureAppConfigurationImpl.ts

@@ -931,7 +931,9 @@ function getValidFeatureFlagSelectors(selectors?: SettingSelector[]): SettingSel
         return [{ keyFilter: `${featureFlagPrefix}${KeyFilter.Any}`, labelFilter: LabelFilter.Null }];
     }
     selectors.forEach(selector => {
-        selector.keyFilter = `${featureFlagPrefix}${selector.keyFilter}`;
+        if (selector.keyFilter) {
+            selector.keyFilter = `${featureFlagPrefix}${selector.keyFilter}`;
+        }
     });
     return getValidSettingSelectors(selectors);
 }

test/featureFlag.test.ts

@@ -5,7 +5,7 @@ import * as chai from "chai";
 import * as chaiAsPromised from "chai-as-promised";
 import { featureFlagContentType } from "@azure/app-configuration";
 import { load } from "./exportedApi.js";
-import { MAX_TIME_OUT, createMockedConnectionString, createMockedEndpoint, createMockedFeatureFlag, createMockedKeyValue, mockAppConfigurationClientListConfigurationSettings, restoreMocks } from "./utils/testHelper.js";
+import { MAX_TIME_OUT, mockAppConfigurationClientGetSnapshot, mockAppConfigurationClientListConfigurationSettingsForSnapshot, createMockedConnectionString, createMockedEndpoint, createMockedFeatureFlag, createMockedKeyValue, mockAppConfigurationClientListConfigurationSettings, restoreMocks } from "./utils/testHelper.js";
 chai.use(chaiAsPromised);
 const expect = chai.expect;
 
@@ -337,4 +337,25 @@ describe("feature flags", function () {
         expect(featureFlag.telemetry.metadata.ETag).equals("ETag");
         expect(featureFlag.telemetry.metadata.FeatureFlagReference).equals(`${createMockedEndpoint()}/kv/.appconfig.featureflag/Telemetry_2?label=Test`);
     });
+
+    it("should load feature flags from snapshot", async () => {
+        const snapshotName = "Test";
+        mockAppConfigurationClientGetSnapshot(snapshotName, {compositionType: "key"});
+        mockAppConfigurationClientListConfigurationSettingsForSnapshot(snapshotName, [[createMockedFeatureFlag("TestFeature", { enabled: true })]]);
+        const connectionString = createMockedConnectionString();
+        const settings = await load(connectionString, {
+            featureFlagOptions: {
+                enabled: true,
+                selectors: [ { snapshotName: snapshotName } ]
+            }
+        });
+        expect(settings).not.undefined;
+        expect(settings.get("feature_management")).not.undefined;
+        const featureFlags = settings.get<any>("feature_management").feature_flags;
+        expect((featureFlags as []).length).equals(1);
+        const featureFlag = featureFlags[0];
+        expect(featureFlag.id).equals("TestFeature");
+        expect(featureFlag.enabled).equals(true);
+        restoreMocks();
+    });
 });

test/load.test.ts

@@ -122,6 +122,25 @@ describe("load", function () {
         return expect(load("invalid-endpoint-url", credential)).eventually.rejectedWith("Invalid URL");
     });
 
+    it("should throw error given invalid selector", async () => {
+        const connectionString = createMockedConnectionString();
+        return expect(load(connectionString, {
+            selectors: [{
+                labelFilter: "\0" 
+            }]
+        })).eventually.rejectedWith("Key filter cannot be null or empty.");
+    });
+
+    it("should throw error given invalid snapshot selector", async () => {
+        const connectionString = createMockedConnectionString();
+        return expect(load(connectionString, {
+            selectors: [{
+                snapshotName: "Test",
+                labelFilter: "\0" 
+            }]
+        })).eventually.rejectedWith("Key or label filter should not be used for a snapshot.");
+    });
+
     it("should not include feature flags directly in the settings", async () => {
         const connectionString = createMockedConnectionString();
         const settings = await load(connectionString);
@@ -419,7 +438,7 @@ describe("load", function () {
         }).to.throw("Invalid separator '%'. Supported values: '.', ',', ';', '-', '_', '__', '/', ':'.");
     });
 
-    it("should load from snapshot", async () => {
+    it("should load key values from snapshot", async () => {
         const snapshotName = "Test";
         mockAppConfigurationClientGetSnapshot(snapshotName, {compositionType: "key"});
         mockAppConfigurationClientListConfigurationSettingsForSnapshot(snapshotName, [[{key: "TestKey", value: "TestValue"}].map(createMockedKeyValue)]);