Skip to content

Commit 5b09aee

Browse files
update
1 parent b5f26c4 commit 5b09aee

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/appConfigurationImpl.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -745,17 +745,19 @@ export class AzureAppConfigurationImpl implements AzureAppConfiguration {
745745

746746
let i = 0;
747747
for await (const page of pageIterator) {
748-
const serverResponseTime = this.#getMsDateHeader(page);
748+
const serverResponseTime: Date = this.#getMsDateHeader(page);
749749
if (i >= pageWatchers.length) {
750750
return true;
751751
}
752752

753753
const lastServerResponseTime = pageWatchers[i].lastServerResponseTime;
754754
let isUpToDate = true;
755-
if (lastServerResponseTime !== undefined && serverResponseTime !== undefined) {
755+
if (lastServerResponseTime !== undefined) {
756756
isUpToDate = serverResponseTime > lastServerResponseTime;
757757
}
758-
if (isUpToDate && page._response.status === 200 && page.etag !== pageWatchers[i].etag) {
758+
if (isUpToDate &&
759+
page._response.status === 200 && // conditional request returns 304 if not changed
760+
page.etag !== pageWatchers[i].etag) {
759761
return true;
760762
}
761763
i++;

0 commit comments

Comments
 (0)