update

Author: zhiyuanliang-ms

src/AzureAppConfigurationImpl.ts

@@ -34,7 +34,7 @@ import { FeatureFlagTracingOptions } from "./requestTracing/FeatureFlagTracingOp
 import { AIConfigurationTracingOptions } from "./requestTracing/AIConfigurationTracingOptions.js";
 import { KeyFilter, LabelFilter, SettingSelector } from "./types.js";
 import { ConfigurationClientManager } from "./ConfigurationClientManager.js";
-import { getFixedBackoffDuration, calculateBackoffDuration } from "./failover.js";
+import { getFixedBackoffDuration, calculateBackoffDuration } from "./backoffDuration.js";
 import { InvalidOperationError, ArgumentError, isFailoverableError, isRetriableError, isArgumentError } from "./error.js";
 
 const MIN_DELAY_FOR_UNHANDLED_FAILURE = 5_000; // 5 seconds

src/ConfigurationClientManager.ts

@@ -7,7 +7,7 @@ import { TokenCredential } from "@azure/identity";
 import { AzureAppConfigurationOptions } from "./AzureAppConfigurationOptions.js";
 import { isBrowser, isWebWorker } from "./requestTracing/utils.js";
 import * as RequestTracing from "./requestTracing/constants.js";
-import { instanceOfTokenCredential, shuffleList } from "./common/utils.js";
+import { shuffleList, instanceOfTokenCredential } from "./common/utils.js";
 import { ArgumentError } from "./error.js";
 
 // Configuration client retry options

src/ConfigurationClientWrapper.ts

@@ -2,7 +2,7 @@
 // Licensed under the MIT license.
 
 import { AppConfigurationClient } from "@azure/app-configuration";
-import { calculateBackoffDuration } from "./failover.js";
+import { calculateBackoffDuration } from "./backoffDuration.js";
 
 export class ConfigurationClientWrapper {
     endpoint: string;

src/failover.ts renamed to src/backoffDuration.ts

@@ -6,13 +6,13 @@ const MAX_BACKOFF_DURATION = 10 * 60 * 1000; // 10 minutes in milliseconds
 const JITTER_RATIO = 0.25;
 
 export function getFixedBackoffDuration(timeElapsed: number): number | undefined {
-    if (timeElapsed <= 100_000) { // 100 seconds in milliseconds
+    if (timeElapsed < 100_000) { // 100 seconds in milliseconds
         return 5_000; // 5 seconds in milliseconds
     }
-    if (timeElapsed <= 200_000) { // 200 seconds in milliseconds
+    if (timeElapsed < 200_000) { // 200 seconds in milliseconds
         return 10_000; // 10 seconds in milliseconds
     }
-    if (timeElapsed <= 10 * 60 * 1000) { // 10 minutes in milliseconds
+    if (timeElapsed < 10 * 60 * 1000) { // 10 minutes in milliseconds
         return MIN_BACKOFF_DURATION;
     }
     return undefined;

src/error.ts

@@ -51,13 +51,15 @@ export function isFailoverableError(error: any): boolean {
 }
 
 export function isRetriableError(error: any): boolean {
-    if (isArgumentError(error) ||
-        error instanceof RangeError) {
+    if (isArgumentError(error)) {
         return false;
     }
     return true;
 }
 
+/**
+ * Check if the error is an instance of ArgumentError, TypeError, or RangeError.
+ */
 export function isArgumentError(error: any): boolean {
     if (error instanceof ArgumentError ||
         error instanceof TypeError ||