always clear cache

Author: zhiyuanliang-ms

src/keyvault/AzureKeyVaultSecretProvider.ts

@@ -9,7 +9,6 @@ import { SecretClient, KeyVaultSecretIdentifier } from "@azure/keyvault-secrets"
 export class AzureKeyVaultSecretProvider {
     #keyVaultOptions: KeyVaultOptions | undefined;
     #secretRefreshTimer: RefreshTimer | undefined;
-    #cacheRefreshTimer: RefreshTimer = new RefreshTimer(24*60*60*1000); // Enforce cache expiration every 24 hours
     #secretClients: Map<string, SecretClient>; // map key vault hostname to corresponding secret client
     #cachedSecretValue: Map<string, any> = new Map<string, any>(); // map secret identifier to secret value
 
@@ -32,8 +31,7 @@ export class AzureKeyVaultSecretProvider {
     }
 
     async getSecretValue(secretIdentifier: KeyVaultSecretIdentifier): Promise<unknown> {
-        // The map key is a combination of sourceId and version: "{sourceId}\n{version}".
-        const identifierKey = `${secretIdentifier.sourceId}\n${secretIdentifier.version ?? ""}`;
+        const identifierKey = secretIdentifier.sourceId;
 
         // If the secret has a version, always use the cached value if available.
         if (secretIdentifier.version && this.#cachedSecretValue.has(identifierKey)) {
@@ -54,19 +52,7 @@ export class AzureKeyVaultSecretProvider {
     }
 
     clearCache(): void {
-        if (this.#cacheRefreshTimer.canRefresh()) {
-            // Clear the cache if the cache expiration timer has expired.
-            this.#cachedSecretValue.clear();
-            this.#cacheRefreshTimer.reset();
-            return;
-        }
-        // If the secret identifier has specified a version, it is not removed from the cache.
-        // If the secret identifier has not specified a version, it means that the latest version should be used. Remove the cached value to force a reload.
-        for (const key of this.#cachedSecretValue.keys()) {
-            if (key.endsWith("\n")) {
-                this.#cachedSecretValue.delete(key);
-            }
-        }
+        this.#cachedSecretValue.clear();
     }
 
     async #getSecretValueFromKeyVault(secretIdentifier: KeyVaultSecretIdentifier): Promise<unknown> {