Skip to content
This repository was archived by the owner on Dec 14, 2022. It is now read-only.

Commit e54feb2

Browse files
author
Chris Wiechmann
committed
Version check must return 200 - To make lookup compatible with
Logstash HTTP-Filter.
1 parent aa8dd32 commit e54feb2

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

apibuilder4elastic/flows/versionLookup-Check version.json

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -75,19 +75,19 @@
7575
"name": "Filebeat version incorrect",
7676
"method": "setresponse",
7777
"parameters": [
78-
{
79-
"name": "status",
80-
"type": "number",
81-
"value": "500",
82-
"metaName": "Status",
83-
"metaDescription": "The HTTP status code"
84-
},
8578
{
8679
"name": "body",
8780
"type": "object",
8881
"value": "{\"message\":\"Filebeat version does not match to API-Builder release\", \"versionStatus\":\"error\"}",
8982
"metaName": "Body",
9083
"metaDescription": "The response payload"
84+
},
85+
{
86+
"name": "status",
87+
"type": "number",
88+
"value": "200",
89+
"metaName": "Status",
90+
"metaDescription": "The HTTP status code"
9191
}
9292
],
9393
"outputs": {
@@ -142,19 +142,19 @@
142142
"name": "Logstash version incorrect",
143143
"method": "setresponse",
144144
"parameters": [
145-
{
146-
"name": "status",
147-
"type": "number",
148-
"value": "500",
149-
"metaName": "Status",
150-
"metaDescription": "The HTTP status code"
151-
},
152145
{
153146
"name": "body",
154147
"type": "object",
155148
"value": "{\"message\":\"Logstash version does not match to API-Builder release\", \"versionStatus\":\"error\"}",
156149
"metaName": "Body",
157150
"metaDescription": "The response payload"
151+
},
152+
{
153+
"name": "status",
154+
"type": "number",
155+
"value": "200",
156+
"metaName": "Status",
157+
"metaDescription": "The HTTP status code"
158158
}
159159
],
160160
"outputs": {

apibuilder4elastic/test/versionCheck/testVersionCheck.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ describe('Endpoints', function () {
2727
uri: `http://localhost:${server.apibuilder.port}/api/elk/v1/api/version/check?filebeatVersion=${filebeatVersion}&logstashVersion=${logstashVersion}`,
2828
json: true
2929
}).then(({ response, body }) => {
30-
expect(response.statusCode).to.equal(500);
30+
expect(response.statusCode).to.equal(200);
3131
expect(body.message).to.equal(`Filebeat version does not match to API-Builder release`);
3232
expect(body.versionStatus).to.equal(`error`);
3333
});
@@ -41,7 +41,7 @@ describe('Endpoints', function () {
4141
uri: `http://localhost:${server.apibuilder.port}/api/elk/v1/api/version/check?filebeatVersion=${filebeatVersion}&logstashVersion=${logstashVersion}`,
4242
json: true
4343
}).then(({ response, body }) => {
44-
expect(response.statusCode).to.equal(500);
44+
expect(response.statusCode).to.equal(200);
4545
expect(body.message).to.equal(`Logstash version does not match to API-Builder release`);
4646
expect(body.versionStatus).to.equal(`error`);
4747
});

0 commit comments

Comments
 (0)