Lookup API now always returns a status code 200 even if

the API could not be found. Fixes issue #109

Author: Chris Wiechmann

apibuilder4elastic/flows/lookupAPI-search.json

@@ -133,19 +133,19 @@
 			"name": "API not found",
 			"method": "setresponse",
 			"parameters": [
-				{
-					"name": "status",
-					"type": "number",
-					"value": "404",
-					"metaName": "Status",
-					"metaDescription": "The HTTP status code"
-				},
 				{
 					"name": "body",
 					"type": "jsonpath",
 					"value": "$.error",
 					"metaName": "Body",
 					"metaDescription": "The response payload"
+				},
+				{
+					"name": "status",
+					"type": "number",
+					"value": "200",
+					"metaName": "Status",
+					"metaDescription": "The HTTP status code"
 				}
 			],
 			"outputs": {

apibuilder4elastic/test/apiLookup/test_apiLookup.js

@@ -61,15 +61,15 @@ describe('Test API-Lookup endpoint', function () {
 			});
 		});
 
-		it('[apilookup-0002] Should return http 404 for an unknown API', () => {
+		it('[apilookup-0002] Should return http 200 for an unknown API', () => {
 			nock('https://mocked-api-gateway:8075').get('/api/portal/v1.3/proxies?field=name&op=eq&value=UnknownAPI').reply(200, '[]');
 			return requestAsync({
 				method: 'GET',
 				uri: `http://localhost:${server.apibuilder.port}/api/elk/v1/api/lookup/api?apiName=UnknownAPI&apiPath=/any/path&groupId=XXXX`, // The groupd doesn't matter for this test
 				auth: auth,
 				json: true
 			}).then(({ response, body }) => {
-				expect(response.statusCode).to.equal(404);
+				expect(response.statusCode).to.equal(200);
 				expect(body).to.be.an('Object');
 				expect(body.message).to.equal(`No APIs found with name: 'UnknownAPI'`);
 				nock.cleanAll();