Fix a few more tests and cover some remaining lines

Author: marcharper

axelrod/strategies/meta.py

@@ -563,8 +563,6 @@ def _post_init(self):
         # deterministic, and we can avoid _random.
         if distribution:
             total = sum(distribution)
-            if total == 0:
-                return
             distribution = np.array(distribution) / total
             if 1 in distribution:
                 self.index = list(distribution).index(1)

axelrod/tests/strategies/test_apavlov.py

@@ -73,7 +73,7 @@ def test_strategy_PavlovD(self):
             opponent, expected_actions=actions, attrs={"opponent_class": "PavlovD"}
         )
 
-    def test_strategy_PavlovD(self):
+    def test_strategy_PavlovD2(self):
         """Tests that PavolvD is identified by DDCDDC and that the response
         is D then C"""
         opponent = axl.MockPlayer(actions=[D, D, C, D, D, C, D])

axelrod/tests/strategies/test_evolvable_player.py

@@ -17,9 +17,6 @@ class PartialedClass(cls):
             seed = kwargs["seed"]
         except KeyError:
             kwargs["seed"] = 1
-        else:
-            if seed is None:
-                kwargs["seed"] = 1
         __init__ = functools.partialmethod(
             cls.__init__, **kwargs)
 
@@ -65,7 +62,7 @@ def player(self, seed=1):
         if seed is None:
             raise Exception()
         params = self.init_parameters.copy()
-        if "seed" not in params:
+        if "seed" not in params:  # pragma: no cover
             params["seed"] = seed
         return self.player_class(**params)
 

axelrod/tests/strategies/test_finite_state_machines.py

@@ -1094,6 +1094,13 @@ def test_create_vector_bounds(self):
         self.assertEqual(lb, [0] * (4 * num_states + 1))
         self.assertEqual(ub, [1] * (4 * num_states + 1))
 
+    def test_mutate(self):
+        """Test to trigger random lines in mutate"""
+        for seed in [18, 22]:
+            player = axl.EvolvableFSMPlayer(
+                num_states=4, mutation_probability=0.5, seed=seed)
+            player.mutate()
+
 
 class TestEvolvableFSMPlayer2(TestEvolvablePlayer):
     name = "EvolvableFSMPlayer"

axelrod/tests/strategies/test_meta.py

@@ -732,21 +732,21 @@ def test_strategy(self):
         # Test TitForTat behavior in first 15 turns
         opponent = axl.Cooperator()
         actions = list([(C, C)]) * 15
-        self.versus_test(opponent, expected_actions=actions)
+        self.versus_test(opponent, expected_actions=actions, seed=1)
 
         opponent = axl.Defector()
         actions = [(C, D)] + list([(D, D)]) * 14
-        self.versus_test(opponent, expected_actions=actions)
+        self.versus_test(opponent, expected_actions=actions, seed=1)
 
         opponent = axl.Alternator()
         actions = [(C, C)] + [(C, D), (D, C)] * 7
-        self.versus_test(opponent, expected_actions=actions)
+        self.versus_test(opponent, expected_actions=actions, seed=1)
 
         opponent_actions = [C, D, D, C, D, C, C, D, C, D, D, C, C, D, D]
         opponent = axl.MockPlayer(actions=opponent_actions)
         mem_actions = [C, C, D, D, C, D, C, C, D, C, D, D, C, C, D]
         actions = list(zip(mem_actions, opponent_actions))
-        self.versus_test(opponent, expected_actions=actions)
+        self.versus_test(opponent, expected_actions=actions, seed=1)
 
     def test_strategy2(self):
         opponent = axl.Random()
@@ -812,3 +812,14 @@ def test_alternative_starting_strategies(self):
                 "start_strategy_duration": 0,
             },
         )
+
+    def test_memory_alter_delete(self):
+        """Trigger memory_alter and memory_delete."""
+        opponent = axl.Cooperator()
+        actions = list([(C, C)]) * 50
+        self.versus_test(
+            opponent,
+            expected_actions=actions,
+            init_kwargs={"start_strategy": axl.Cooperator},
+            seed=11
+        )

axelrod/tests/strategies/test_player.py

@@ -656,7 +656,7 @@ def versus_test(
             for attr, value in attrs.items():
                 self.assertEqual(getattr(player1, attr), value)
 
-    def search_seeds(self, *args, **kwargs):
+    def search_seeds(self, *args, **kwargs):  # pragma: no cover
         """Search for a seed that will pass the test. To use to find a new seed
         for a versus_test, change self.versus_test to self.search_seeds
         within a TestPlayer or TestMatch class.

axelrod/tests/strategies/test_rand.py

@@ -34,7 +34,7 @@ def test_stochastic_behavior1(self):
         actions = [(C, C), (D, C), (D, C), (C, C)]
         self.versus_test(opponent, expected_actions=actions, seed=1)
 
-    def test_stochastic_behavior1(self):
+    def test_stochastic_behavior2(self):
         opponent = axl.MockPlayer()
         actions = [(D, C), (C, C), (D, C)]
         self.versus_test(opponent, expected_actions=actions, seed=2)