Merge pull request #880 from Automattic/issue/879-note-sync-pause

Issue/879 note sync pause

Author: anitaa1990

Simplenote/src/main/java/com/automattic/simplenote/NoteEditorFragment.java

@@ -127,6 +127,7 @@ public void run() {
     private String mMatchOffsets;
     private int mCurrentCursorPosition;
     private HistoryBottomSheetDialog mHistoryBottomSheet;
+    private boolean mIsPaused;
     // Hides the history bottom sheet if no revisions are loaded
     private final Runnable mHistoryTimeoutRunnable = new Runnable() {
         @Override
@@ -434,9 +435,7 @@ public void run() {
     @Override
     public void onPause() {
         super.onPause();  // Always call the superclass method first
-
-        mNotesBucket.removeListener(this);
-        mNotesBucket.stop();
+        mIsPaused = true;
 
         // Hide soft keyboard if it is showing...
         DisplayUtils.hideKeyboard(mContentEditText);
@@ -459,6 +458,13 @@ public void onPause() {
         saveNote();
     }
 
+    @Override
+    public void onDestroy() {
+        super.onDestroy();
+        mNotesBucket.removeListener(this);
+        mNotesBucket.stop();
+    }
+
     @Override
     public void onSaveInstanceState(@NonNull Bundle outState) {
         super.onSaveInstanceState(outState);
@@ -1234,7 +1240,10 @@ public void run() {
 
     @Override
     public void onSaveObject(Bucket<Note> noteBucket, Note note) {
-        // noop
+        if (mIsPaused) {
+            mNotesBucket.removeListener(this);
+            mNotesBucket.stop();
+        }
     }
 
     @Override