Skip to content

Commit 604ba09

Browse files
committed
Merge pull request #774 from LinusU/fix-data-leak
Fix leak of data when streaming JPEG
2 parents 258797c + ba7422a commit 604ba09

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/JPEGStream.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ term_closure_destination(j_compress_ptr cinfo){
5353
closure_destination_mgr *dest = (closure_destination_mgr *) cinfo->dest;
5454

5555
/* emit remaining data */
56-
Local<Object> buf = Nan::NewBuffer((char *)dest->buffer, dest->bufsize).ToLocalChecked();
56+
Local<Object> buf = Nan::NewBuffer((char *)dest->buffer, dest->bufsize - dest->pub.free_in_buffer).ToLocalChecked();
5757

5858
Local<Value> data_argv[2] = {
5959
Nan::Null()

test/canvas.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -817,7 +817,7 @@ describe('Canvas', function () {
817817
bytes += chunk.length;
818818
});
819819
stream.on('end', function(){
820-
assert.equal(bytes, 8192);
820+
assert.equal(bytes, 5427);
821821
done();
822822
});
823823
stream.on('error', function(err) {

0 commit comments

Comments
 (0)