Functions/DynamicCalls: bug fix - allow for double quotes

Text strings can use both single quotes as well as double quotes.

When the text string contains an interpolated variable, it will be tokenized as `T_DOUBLE_QUOTED_STRING`, but when it is a plain text string, a double quoted text string will be tokenized as `T_CONSTANT_ENCAPSED_STRING`, same as single quoted text string.

The sniff did not take this into account, leading to false negatives.

The sniff also would strip quotes from within a text - `'my\'text'` - . This did not cause a problem for this sniff as function names cannot have back slashes in them, but it was still wrong.

Fixed now by using the WPCS `strip_quotes()` method.

Includes unit test which would fail previously.

Author: jrfnl

WordPressVIPMinimum/Sniffs/Functions/DynamicCallsSniff.php

@@ -141,9 +141,9 @@ private function collect_variables() {
 		 *
 		 * Register its name and value in the internal array for later usage.
 		 */
-		$current_var_value = $this->tokens[ $value_ptr ]['content'];
+		$current_var_value = $this->strip_quotes( $this->tokens[ $value_ptr ]['content'] );
 
-		$this->variables_arr[ $current_var_name ] = str_replace( "'", '', $current_var_value );
+		$this->variables_arr[ $current_var_name ] = $current_var_value;
 	}
 
 	/**

WordPressVIPMinimum/Tests/Functions/DynamicCallsUnitTest.inc

@@ -30,3 +30,6 @@ $test_getting_the_actual_value_4 = 'get_defined_vars' . $source;
 $test_getting_the_actual_value_4(); // OK. Unclear what the actual variable value will be.
 
 $ensure_no_notices_are_thrown_on_parse_error = /*comment*/ ;
+
+$test_double_quoted_string = "assert";
+$test_double_quoted_string(); // Bad.

WordPressVIPMinimum/Tests/Functions/DynamicCallsUnitTest.php

@@ -27,6 +27,7 @@ public function getErrorList() {
 		return [
 			9  => 1,
 			15 => 1,
+			35 => 1,
 		];
 	}