Merge pull request #817 from Automattic/deprecate/get_page_by_path

Deprecate suggesting using wpcom_vip_get_page_by_path

Author: GaryJones

WordPressVIPMinimum/Sniffs/Functions/RestrictedFunctionsSniff.php

@@ -269,13 +269,6 @@ public function getGroups() {
 					'create_function',
 				],
 			],
-			'get_page_by_path' => [
-				'type'      => 'warning',
-				'message'   => '%s() is highly discouraged due to not being cached; please use wpcom_vip_get_page_by_path() instead.',
-				'functions' => [
-					'get_page_by_path',
-				],
-			],
 		];
 
 		$deprecated_vip_helpers = [

WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.inc

@@ -222,8 +222,8 @@ $wp_random_testing = create_function3( '$a, $b', 'return ( $b / $a ); '); // Ok.
 
 
 
-wpcom_vip_get_page_by_path(); // Ok - VIP recommended version of get_page_by_path().
-get_page_by_path( $page_path ); // Warning.
+
+
 
 $popular = stats_get_csv( 'postviews', [ 'days'  => 2,   'limit' => 20 ] ); // Error.
 $popular = custom_stats_get_csv( 'postviews', [ 'days'  => 2,   'limit' => 20 ] ); // Ok.

WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.php

@@ -121,7 +121,6 @@ public function getWarningList() {
 			138 => 1,
 			139 => 1,
 			208 => 1,
-			226 => 1,
 		];
 	}
 }