Merge pull request #464 from Automattic/fix_461

RestrictedFunctions: Add stats_get_csv()

Author: rebeccahum

WordPressVIPMinimum/Sniffs/Functions/RestrictedFunctionsSniff.php

@@ -268,6 +268,13 @@ public function getGroups() {
 					'delete_site_option',
 				],
 			],
+			'stats_get_csv' => [
+				'type'      => 'error',
+				'message'   => 'Using `%s` outside of Jetpack context pollutes the stats_cache entry in the wp_options table. We recommend building a custom function instead.',
+				'functions' => [
+					'stats_get_csv',
+				]
+			],
 			'wp_mail' => [
 				'type'      => 'warning',
 				'message'   => '`%s` should be used sparingly. For any bulk emailing should be handled by a 3rd party service, in order to prevent domain or IP addresses being flagged as spam.',

WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.inc

@@ -224,3 +224,6 @@ delete_option(  $bar ); // Ok.
 
 wpcom_vip_get_page_by_path(); // Ok - VIP recommended version of get_page_by_path().
 get_page_by_path( $page_path ); // Warning.
+
+$popular = stats_get_csv( 'postviews', [ 'days'  => 2,   'limit' => 20 ] ); // Error.
+$popular = custom_stats_get_csv( 'postviews', [ 'days'  => 2,   'limit' => 20 ] ); // Ok.

WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.php

@@ -109,6 +109,7 @@ public function getErrorList() {
 			218 => 1,
 			220 => 1,
 			222 => 1,
+			228 => 1,
 		];
 	}