Skip to content

Commit 4094eec

Browse files
committed
Update ruleset tests: account for new errors from WPCS
* The `WordPress.Security.ValidatedSanitizedInput` sniff will now also examine `$_SESSION` variables. As the test is about another sniff, let's just ignore the notices coming from `WordPress.Security.ValidatedSanitizedInput`.
1 parent 436b0fe commit 4094eec

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

WordPress-VIP-Go/ruleset-test.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,7 @@ echo "<script>
557557
</article> <?php
558558

559559
// WordPressVIPMinimum.Variables.RestrictedVariables
560-
foo( $_SESSION['bar'] ); // Error.
560+
foo( $_SESSION['bar'] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput -- Error.
561561

562562
// WordPressVIPMinimum.Variables.ServerVariables
563563
// phpcs:disable WordPress.Security.ValidatedSanitizedInput.InputNotValidated,WordPress.Security.ValidatedSanitizedInput.InputNotSanitized

WordPressVIPMinimum/ruleset-test.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,7 @@ echo '<style type="text/css">.show-admin-bar { visibility: hidden; }</style>'; /
587587
// WordPressVIPMinimum.Variables.RestrictedVariables
588588
$query = "SELECT * FROM $wpdb->users"; // Error.
589589
$x = foo( sanitize_text_field( $_SERVER['HTTP_USER_AGENT'] ) ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotValidated -- Warning.
590-
foo( $_SESSION['bar'] ); // Error.
590+
foo( $_SESSION['bar'] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput -- Error.
591591

592592
// WordPressVIPMinimum.Variables.ServerVariables
593593
// phpcs:disable WordPress.Security.ValidatedSanitizedInput.InputNotValidated,WordPress.Security.ValidatedSanitizedInput.InputNotSanitized

0 commit comments

Comments
 (0)