Skip to content

Commit 288159a

Browse files
committed
Silence rather than exclude for more user customization
1 parent 53469f5 commit 288159a

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

WordPress-VIP-Go/ruleset.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,9 @@
257257
</rule>
258258

259259
<!-- Silence is golden, these don't affect us on VIP Go -->
260+
<rule ref="VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable">
261+
<severity>0</severity>
262+
</rule>
260263
<rule ref="WordPress.DB.SlowDBQuery.slow_db_query_meta_key">
261264
<!-- We are silencing this one because VIP Go has a combined index on meta_key, meta_value-->
262265
<severity>0</severity>

WordPressVIPMinimum/ruleset.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -144,9 +144,7 @@
144144
</rule>
145145

146146
<!-- Include VariableAnalysis checks -->
147-
<rule ref="VariableAnalysis">
148-
<exclude name="VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable"/>
149-
</rule>
147+
<rule ref="VariableAnalysis"/>
150148

151149
<!-- Prevent deprecation notice when the sniff is not explicitly included. -->
152150
<rule ref="WordPressVIPMinimum.Variables.VariableAnalysis.DeprecatedSniff">

0 commit comments

Comments
 (0)