Drag Mode Camera Focus Fix [AARD-2028] (#1245)

Co-authored-by: Alexey Dmitriev <157652245+AlexD717@users.noreply.github.com>

Author: BrandonPacewic

fission/src/mirabuf/MirabufSceneObject.ts

@@ -867,7 +867,7 @@ class MirabufSceneObject extends SceneObject implements ContextSupplier {
                 data.items.push({
                     name: "Camera: Unfocus",
                     func: () => {
-                        cameraControls.focusProvider = undefined
+                        cameraControls.unfocus()
                     },
                 })
 

fission/src/systems/scene/CameraControls.ts

@@ -95,6 +95,7 @@ export class CustomOrbitControls extends CameraControls {
     private _focus: THREE.Matrix4
 
     private _focusProvider: MirabufSceneObject | undefined
+    private _isExplicitlyUnfocused: boolean = false
     public locked: boolean
 
     private _interactionHandler: ScreenInteractionHandler
@@ -108,11 +109,22 @@ export class CustomOrbitControls extends CameraControls {
 
     public set focusProvider(provider: MirabufSceneObject | undefined) {
         this._focusProvider = provider
+        if (provider !== undefined) {
+            this._isExplicitlyUnfocused = false
+        }
     }
     public get focusProvider() {
         return this._focusProvider
     }
 
+    /**
+     * Explicitly unfocus the camera (user-initiated action)
+     */
+    public unfocus(): void {
+        this._focusProvider = undefined
+        this._isExplicitlyUnfocused = true
+    }
+
     public get coords(): SphericalCoords {
         return this._coords
     }
@@ -166,7 +178,7 @@ export class CustomOrbitControls extends CameraControls {
      * If not, automatically finds a suitable replacement.
      */
     private validateFocusProvider(): void {
-        if (!World.sceneRenderer?.sceneObjects) {
+        if (!World.sceneRenderer?.sceneObjects || World.dragModeSystem.isTransitioning) {
             return
         }
 
@@ -176,8 +188,9 @@ export class CustomOrbitControls extends CameraControls {
         if (this._focusProvider) {
             if (!mirabufObjects.includes(this._focusProvider)) {
                 this._focusProvider = this.findFallbackFocus(mirabufObjects)
+                this._isExplicitlyUnfocused = false
             }
-        } else {
+        } else if (!this._isExplicitlyUnfocused) {
             this._focusProvider = this.findFallbackFocus(mirabufObjects)
         }
     }

fission/src/systems/scene/DragModeSystem.ts

@@ -112,6 +112,10 @@ class DragModeSystem extends WorldSystem {
         return this._enabled
     }
 
+    public get isTransitioning(): boolean {
+        return this._cameraTransition.isTransitioning
+    }
+
     public set enabled(enabled: boolean) {
         if (this._enabled === enabled) return