chore: remove old TODOs

Author: azaleacolburn

fission/src/mirabuf/MirabufParser.ts

@@ -213,11 +213,6 @@ class MirabufParser {
                     .filter(([_key, subInst]) => inst === subInst)
                     .forEach(([key, _subInst]) => delete this._assembly.data?.parts?.partInstances?.[key])
 
-                // Delete partDefinitions
-                // Object.entries(this._assembly.data?.parts?.partDefinitions ?? {})
-                //     .filter(([_key, subInst]) => inst === subInst)
-                //     .forEach(([key, _subInst]) => delete this._assembly.data?.parts?.partDefinitions?.[key])
-
                 return this.convertPartInstanceToAssembly(inst, instNode)
             })
             .filter(asm => asm != undefined)
@@ -389,7 +384,7 @@ class MirabufParser {
     private loadGlobalTransforms() {
         const root = this._designHierarchyRoot
         const parts = this._assembly.data?.parts
-        if (!parts) return // TODO not sure if we should return or provide a default value
+        if (!parts) return
 
         const partInstances = new Map<string, mirabuf.IPartInstance>(Object.entries(parts.partInstances!))
         const partDefinitions = parts.partDefinitions!

fission/src/ui/modals/configuring/SettingsModal.tsx

@@ -165,7 +165,6 @@ const GeneralTab: React.FC<GeneralTabProps> = ({ writePreference }) => (
                 onClick={checked => {
                     writePreference("RenderScoreboard", checked)
                     if (checked) {
-                        // TODO: figure out scoreboard - I think it should be its own component and not a panel
                         // openPanel("scoreboard");
                     }
                 }}

fission/src/ui/modals/mirabuf/ImportLocalMirabufModal.tsx

@@ -51,11 +51,9 @@ const ImportLocalMirabufModal: React.FC<ModalImplProps<void, void>> = ({ modal }
                 World.physicsSystem.holdPause(PAUSE_REF_ASSEMBLY_SPAWNING)
                 await MirabufCachingService.cacheAndGetLocalWithInfo(hashBuffer, miraType)
                     .then(x => {
-                        if (x) {
-                            // TODO This function shouldn't cache game pieces when imported locally!!!
-                            return createMirabuf(x.assembly, x.cacheInfo.id, miraType)
-                        }
-                        return undefined
+                        if (!x) return undefined
+
+                        return createMirabuf(x.assembly, x.cacheInfo.id, miraType)
                     })
                     .then(x => {
                         if (x) {
@@ -66,7 +64,6 @@ const ImportLocalMirabufModal: React.FC<ModalImplProps<void, void>> = ({ modal }
                                 const assembly = instance.parser.assembly
                                 const buffer = mirabuf.Assembly.encode(assembly).finish().buffer as ArrayBuffer
 
-                                // TOOD Fix
                                 const cacheInfo = await MirabufCachingService.cacheLocal(buffer, MiraType.PIECE)
                                 if (!cacheInfo) return
 
@@ -84,7 +81,6 @@ const ImportLocalMirabufModal: React.FC<ModalImplProps<void, void>> = ({ modal }
 
                             console.log(`Loaded ${mainSceneObject.miraType.toString()} Locally`)
                             if (mainSceneObject.miraType === MiraType.ROBOT) {
-                                // TOOD See if passing undefined is ok
                                 globalOpenPanel(InitialConfigPanel, undefined)
                             }
                         }

fission/src/ui/panels/simulation/DriverStationPanel.tsx

@@ -9,13 +9,8 @@ const DriverStationPanel: React.FC<PanelImplProps<void, void>> = ({ panel }) =>
     const [enabled, setEnabled] = useState(false)
 
     useEffect(() => {
-        // TODO: update Not Connected dynamically when implemented
         configureScreen(panel!, { title: "Driver Station (Not Connected)" }, {})
-    }, [
-        // TODO: update Not Connected dynamically when implemented
-        configureScreen,
-        panel,
-    ])
+    }, [configureScreen, panel])
 
     return (
         <Stack direction="row">