fix: prevent custom configs from showing as defaults

rutmanz · rutmanz · commit 9786dfc15923 · 2025-08-01T09:52:03.000-07:00
diff --git a/fission/src/ui/panels/configuring/MatchModeConfigPanel.tsx b/fission/src/ui/panels/configuring/MatchModeConfigPanel.tsx
@@ -231,11 +231,13 @@ const MatchModeConfigPanel: React.FC<PanelPropsImpl> = ({ panelId }) => {
             return null
         }
 
-        // If validation passes, normalize the config with defaults for missing fields
-        return {
+        // If validation passes, use the default values in any missing fields
+        const normalizedConfig = {
             ...DefaultMatchModeConfigs.fallbackValues(),
             ...configObj,
         }
+        normalizedConfig.isDefault = false
+        return normalizedConfig
     }
 
     const handleFileUpload = async (file: File) => {

Original file line number	Diff line number	Diff line change
`@@ -231,11 +231,13 @@ const MatchModeConfigPanel: React.FC<PanelPropsImpl> = ({ panelId }) => {`
`231`	`231`	`return null`
`232`	`232`	`}`
`233`	`233`
`234`		`- // If validation passes, normalize the config with defaults for missing fields`
`235`		`- return {`
	`234`	`+ // If validation passes, use the default values in any missing fields`
	`235`	`+ const normalizedConfig = {`
`236`	`236`	`...DefaultMatchModeConfigs.fallbackValues(),`
`237`	`237`	`...configObj,`
`238`	`238`	`}`
	`239`	`+ normalizedConfig.isDefault = false`
	`240`	`+ return normalizedConfig`
`239`	`241`	`}`
`240`	`242`
`241`	`243`	`const handleFileUpload = async (file: File) => {`