Per Incident Penalty

Author: AlexD717

fission/src/systems/match_mode/RobotDimensionTracker.ts

@@ -4,10 +4,10 @@ import SceneRenderer from "../scene/SceneRenderer"
 import MatchMode from "./MatchMode"
 import SimulationSystem from "@/systems/simulation/SimulationSystem"
 
-const PENALTY_COOLDOWN = 1000
+const BUFFER_HEIGHT = 0.1
 
 class RobotDimensionTracker {
-    private static _robotHeightPenalties: Map<number, number> = new Map()
+    private static _robotLastFramePenalty: Map<number, boolean> = new Map()
     private static _ignoreRotation: boolean = true
     private static _maxHeight: number = Infinity
     private static _heightPenalty: number = 0
@@ -28,11 +28,13 @@ class RobotDimensionTracker {
         robots.forEach(robot => {
             const dimensions = this._ignoreRotation ? robot.getDimensionsWithoutRotation() : robot.getDimensions()
 
-            if (dimensions.height > this._maxHeight) {
-                if ((this._robotHeightPenalties.get(robot.id) ?? 0) < Date.now() - PENALTY_COOLDOWN) {
-                    this._robotHeightPenalties.set(robot.id, Date.now() + this._heightPenalty)
+            if (dimensions.height > this._maxHeight + BUFFER_HEIGHT) {
+                if (!(this._robotLastFramePenalty.get(robot.id) ?? false)) {
                     SimulationSystem.robotPenalty(robot, this._heightPenalty, "Height Expansion Limit")
                 }
+                this._robotLastFramePenalty.set(robot.id, true)
+            } else {
+                this._robotLastFramePenalty.set(robot.id, false)
             }
         })
     }

fission/src/test/RobotDimensionsTracker.test.ts

@@ -66,8 +66,8 @@ describe("RobotDimensionTracker", () => {
     beforeEach(() => {
         vi.clearAllMocks()
 
-        const tracker = RobotDimensionTracker as unknown as { _robotHeightPenalties?: Map<string, number> }
-        tracker._robotHeightPenalties?.clear()
+        const tracker = RobotDimensionTracker as unknown as { _robotLastFramePenalty?: Map<number, boolean> }
+        tracker._robotLastFramePenalty?.clear()
 
         const robot1Base = Object.create(MirabufSceneObject.prototype)
         const robot2Base = Object.create(MirabufSceneObject.prototype)