Skip to content

Commit 345b847

Browse files
committed
New Icon & Number.MAX_SAFE_INTEGER instead of infinity
1 parent 5cff22b commit 345b847

File tree

3 files changed

+10
-11
lines changed

3 files changed

+10
-11
lines changed

fission/src/systems/match_mode/DefaultMatchModeConfigs.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class DefaultMatchModeConfigs {
1212
teleopTime: 135,
1313
endgameTime: 20,
1414
ignoreRotation: true,
15-
maxHeight: Infinity,
15+
maxHeight: Number.MAX_SAFE_INTEGER,
1616
heightLimitPenalty: 0,
1717
sideMaxExtension: convertFeetToMeters(1.5),
1818
sideExtensionPenalty: 0,
@@ -60,9 +60,9 @@ class DefaultMatchModeConfigs {
6060
teleopTime: 15,
6161
endgameTime: 5,
6262
ignoreRotation: true,
63-
maxHeight: Infinity,
63+
maxHeight: Number.MAX_SAFE_INTEGER,
6464
heightLimitPenalty: 0,
65-
sideMaxExtension: Infinity,
65+
sideMaxExtension: Number.MAX_SAFE_INTEGER,
6666
sideExtensionPenalty: 0,
6767
}
6868
}
@@ -76,9 +76,9 @@ class DefaultMatchModeConfigs {
7676
teleopTime: 135,
7777
endgameTime: 20,
7878
ignoreRotation: true,
79-
maxHeight: Infinity,
79+
maxHeight: Number.MAX_SAFE_INTEGER,
8080
heightLimitPenalty: 2,
81-
sideMaxExtension: Infinity,
81+
sideMaxExtension: Number.MAX_SAFE_INTEGER,
8282
sideExtensionPenalty: 2,
8383
}
8484
}

fission/src/ui/components/StyledComponents.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import {
1515
FaGear,
1616
FaMagnifyingGlass,
1717
FaMinus,
18-
FaPlay,
1918
FaPlus,
2019
FaQuestion,
2120
FaScrewdriverWrench,
@@ -25,7 +24,7 @@ import {
2524
import { GiSteeringWheel } from "react-icons/gi"
2625
import { GrConnect } from "react-icons/gr"
2726
import { HiDownload } from "react-icons/hi"
28-
import { IoCheckmark, IoPencil, IoPeople, IoTrashBin } from "react-icons/io5"
27+
import { IoCheckmark, IoPencil, IoPeople, IoPlayOutline, IoTrashBin } from "react-icons/io5"
2928
import Label from "./Label"
3029

3130
export class SynthesisIcons {
@@ -51,7 +50,7 @@ export class SynthesisIcons {
5150
public static readonly CONNECT = <GrConnect />
5251
public static readonly INFO = <AiOutlineInfoCircle />
5352
public static readonly BUG = <FaBug />
54-
public static readonly PLAY = <FaPlay />
53+
public static readonly PLAY = <IoPlayOutline />
5554

5655
/** Large icons: used for icon buttons */
5756
public static readonly DELETE_LARGE = <IoTrashBin size={"1.25rem"} />
@@ -64,7 +63,7 @@ export class SynthesisIcons {
6463
public static readonly LEFT_ARROW_LARGE = <FaArrowLeft size={"1.25rem"} />
6564
public static readonly BUG_LARGE = <FaBug size={"1.25rem"} />
6665
public static readonly XMARK_LARGE = <FaXmark size={"1.25rem"} />
67-
public static readonly PLAY_LARGE = <FaPlay size={"1.25rem"} />
66+
public static readonly PLAY_LARGE = <IoPlayOutline size={"1.25rem"} />
6867

6968
public static readonly OPEN_HUD_ICON = (
7069
<FaAngleRight

fission/src/ui/panels/configuring/CreateNewMatchModeConfigPanel.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ const FIELD_CONFIGS: Record<string, FieldConfig> = {
9191
type: "checkbox",
9292
},
9393
maxHeight: {
94-
defaultValue: fallbackConfig.maxHeight === Infinity ? 1.2 : fallbackConfig.maxHeight,
94+
defaultValue: fallbackConfig.maxHeight === Number.MAX_SAFE_INTEGER ? 1.2 : fallbackConfig.maxHeight,
9595
rules: [VALIDATION_RULES.nonNegativeNumber("Max height must be a non-negative number")],
9696
type: "decimal",
9797
},
@@ -106,7 +106,7 @@ const FIELD_CONFIGS: Record<string, FieldConfig> = {
106106
type: "checkbox",
107107
},
108108
sideMaxExtension: {
109-
defaultValue: fallbackConfig.sideMaxExtension === Infinity ? 0.5 : fallbackConfig.sideMaxExtension,
109+
defaultValue: fallbackConfig.sideMaxExtension === Number.MAX_SAFE_INTEGER ? 0.5 : fallbackConfig.sideMaxExtension,
110110
rules: [VALIDATION_RULES.nonNegativeNumber("Side max extension must be a non-negative number")],
111111
type: "decimal",
112112
},

0 commit comments

Comments
 (0)