Merging Dev and Formatting

Author: Dhruv-0-Arora

README.md

@@ -5,7 +5,7 @@
 
 [![Fission - Unit Test](https://github.com/Autodesk/synthesis/actions/workflows/FissionUnitTest.yml/badge.svg?branch=prod)](https://github.com/Autodesk/synthesis/actions/workflows/FissionUnitTest.yml)
 [![Fission - Packaging](https://github.com/Autodesk/synthesis/actions/workflows/FissionPackage.yml/badge.svg?branch=prod)](https://github.com/Autodesk/synthesis/actions/workflows/FissionPackage.yml)
-[![Fission - Lint/Format](https://github.com/Autodesk/synthesis/actions/workflows/FissionESLintFormat.yml/badge.svg?branch=prod)](https://github.com/Autodesk/synthesis/actions/workflows/FissionESLintFormat.yml)
+[![Fission - Lint/Format](https://github.com/Autodesk/synthesis/actions/workflows/FissionBiome.yml/badge.svg?branch=prod)](https://github.com/Autodesk/synthesis/actions/workflows/FissionBiome.yml)
 [![Fusion - Format](https://github.com/Autodesk/synthesis/actions/workflows/BlackFormat.yml/badge.svg?branch=prod)](https://github.com/Autodesk/synthesis/actions/workflows/BlackFormat.yml)
 
 Synthesis is a robotics simulator designed by and for [FIRST®](https://www.firstinspires.org/) robotics students to help teams design, strategize, test and practice. Teams have the ability to import their own robots and fields using our [Fusion Exporter](/exporter/) or use the pre-made ones available within Synthesis.

exporter/SynthesisFusionAddin/src/UI/DesignCheckTab.py

@@ -8,6 +8,7 @@
 
 logger = Logging.getLogger()
 
+
 class DesignRule(TypedDict):
     name: str
     calculation: Callable[[], float]
@@ -86,7 +87,7 @@ def fusion_design_height(self) -> float:
         design = adsk.fusion.Design.cast(gm.app.activeProduct)
         if design:
             overall_bounding_box = design.rootComponent.orientedMinimumBoundingBox
-            return float(overall_bounding_box.width) 
+            return float(overall_bounding_box.width)
         return 0.0
 
     @Logging.logFailure

fission/.eslintrc.cjs

@@ -13,10 +13,14 @@
     "bracketSameLine": false,
     "bracketSpacing": true,
     "expand": "auto",
-    "useEditorconfig": true
+    "useEditorconfig": true,
+    "includes": ["src/**", "!dist"]
   },
   "linter": {
     "enabled": true,
+    "domains": {
+      "react": "all"
+    },
     "rules": {
       "recommended": false,
       "complexity": {
@@ -25,6 +29,7 @@
         "noExtraBooleanCast": "error",
         "noUselessCatch": "error",
         "noUselessEscapeInRegex": "error",
+        "noUselessThisAlias": "error",
         "noUselessTypeConstraint": "error"
       },
       "correctness": {
@@ -46,6 +51,7 @@
         "noUnsafeFinally": "error",
         "noUnsafeOptionalChaining": "error",
         "noUnusedLabels": "error",
+        "noUnusedImports": "error",
         "noUnusedVariables": "error",
         "useExhaustiveDependencies": "warn",
         "useHookAtTopLevel": "error",
@@ -54,12 +60,69 @@
         "useValidTypeof": "error",
         "useYield": "error"
       },
+      "nursery": { "noTsIgnore": "error", "noUselessBackrefInRegex": "error" },
       "style": {
         "noNamespace": "error",
         "useArrayLiterals": "error",
-        "useAsConstAssertion": "error"
+        "useAsConstAssertion": "error",
+        "useComponentExportOnlyModules": "warn",
+        "useNamingConvention": {
+          "level": "warn",
+          "options": {
+            "strictCase": false,
+            "requireAscii": true,
+            "conventions": [
+              { "selector": { "kind": "class" }, "match": "([^_]*)", "formats": ["PascalCase"] },
+              {
+                "selector": { "kind": "classProperty", "modifiers": ["readonly", "static"] },
+                "match": "[^_]((.*)[^_])?",
+                "formats": ["CONSTANT_CASE"]
+              },
+              { "selector": { "kind": "classMethod" }, "match": "([^_]*)", "formats": ["camelCase"] },
+              {
+                "selector": { "kind": "classMember", "modifiers": ["private"] },
+                "match": "_([^_]*)",
+                "formats": ["camelCase"]
+              },
+
+              { "selector": { "kind": "enumMember" }, "match": "[^_]((.*)[^_])?", "formats": ["CONSTANT_CASE"] },
+              { "selector": { "kind": "function" }, "match": "([^_]*)", "formats": ["camelCase"] },
+
+              { "selector": { "kind": "objectLiteralMethod" }, "match": "([^_]*)", "formats": ["camelCase"] },
+              {
+                "selector": { "kind": "objectLiteralProperty" },
+                "match": "[^_]((.*)[^_])?",
+                "formats": ["camelCase", "snake_case", "PascalCase", "CONSTANT_CASE"]
+              },
+              { "selector": { "kind": "typeMethod" }, "match": "(.*)[^_]", "formats": ["camelCase"] },
+              { "selector": { "kind": "typeProperty" }, "match": "(.*)[^_]", "formats": ["camelCase", "PascalCase"] },
+              { "selector": { "kind": "classMethod" }, "match": "(.*)[^_]", "formats": ["camelCase"] },
+              {
+                "selector": { "kind": "importNamespace" },
+                "match": "([^_]*)",
+                "formats": ["camelCase", "PascalCase", "CONSTANT_CASE"]
+              },
+              {
+                "selector": { "kind": "importAlias" },
+                "match": "([^_]*)",
+                "formats": ["camelCase", "PascalCase", "CONSTANT_CASE"]
+              },
+
+              { "selector": { "kind": "functionParameter" }, "match": "([^_]*)", "formats": ["camelCase"] },
+              {
+                "selector": { "kind": "const" },
+                "match": "[^_]((.*)[^_])?",
+                "formats": ["PascalCase", "camelCase", "CONSTANT_CASE"]
+              },
+              { "selector": { "kind": "variable" }, "match": "[^_]((.*)[^_])?", "formats": ["camelCase"] },
+              { "selector": { "kind": "typeLike" }, "match": "([^_]*)", "formats": ["PascalCase", "camelCase"] },
+              { "match": "_?([^_]*)", "formats": ["camelCase"] }
+            ]
+          }
+        }
       },
       "suspicious": {
+        "noAssignInExpressions": "error",
         "noAsyncPromiseExecutor": "error",
         "noCatchAssign": "error",
         "noClassAssign": "error",
@@ -91,7 +154,7 @@
         "useGetterReturn": "error"
       }
     },
-    "includes": ["**/*.{ts,tsx}", "src/proto/mirabuf.*", "src/samples/*"]
+    "includes": ["src/**/*.{ts,tsx,js,json}", "./*.{ts,js,json,html}"]
   },
   "javascript": {
     "formatter": {
@@ -101,47 +164,19 @@
       "semicolons": "asNeeded",
       "arrowParentheses": "asNeeded",
       "bracketSameLine": false,
+      "indentStyle": "space",
+      "indentWidth": 4,
       "quoteStyle": "double",
       "attributePosition": "auto",
       "bracketSpacing": true
-    }
+    },
+    "globals": ["COMMIT_HASH"]
   },
   "html": { "formatter": { "selfCloseVoidElements": "always" } },
   "overrides": [
-    {
-      "includes": ["*.ts", "*.tsx", "*.mts", "*.cts"],
-      "linter": {
-        "rules": {
-          "complexity": { "noArguments": "error" },
-          "correctness": {
-            "noConstAssign": "off",
-            "noGlobalObjectCalls": "off",
-            "noInvalidBuiltinInstantiation": "off",
-            "noInvalidConstructorSuper": "off",
-            "noSetterReturn": "off",
-            "noUndeclaredVariables": "off",
-            "noUnreachable": "off",
-            "noUnreachableSuper": "off"
-          },
-          "style": { "useConst": "error" },
-          "suspicious": {
-            "noDuplicateClassMembers": "off",
-            "noDuplicateObjectKeys": "off",
-            "noDuplicateParameters": "off",
-            "noFunctionAssign": "off",
-            "noImportAssign": "off",
-            "noRedeclare": "off",
-            "noUnsafeNegation": "off",
-            "noVar": "error",
-            "useGetterReturn": "off"
-          }
-        }
-      }
-    },
-    { "includes": ["*.json"], "formatter": { "indentWidth": 2 } }
+    { "includes": ["*.json"], "formatter": { "indentWidth": 2 } },
+    { "includes": ["src/proto/**/*"], "linter": { "enabled": false } }
   ],
-  "assist": {
-    "enabled": true,
-    "actions": { "source": { "organizeImports": "on" } }
-  }
+
+  "assist": { "enabled": true, "actions": { "source": { "organizeImports": "on" } } }
 }