Graceful migration from old prefs to new

Author: AlexD717

fission/src/systems/preferences/PreferencesSystem.ts

@@ -102,7 +102,11 @@ class PreferencesSystem {
             return defaultPrefs
         }
 
-        return allRoboPrefs[miraName]
+        const defaultPrefs = defaultRobotPreferences()
+        const mergedPrefs = { ...defaultPrefs, ...allRoboPrefs[miraName] }
+        allRoboPrefs[miraName] = mergedPrefs
+
+        return mergedPrefs
     }
 
     /** Sets the RobotPreferences object for the robot of a specific mira name */
@@ -148,7 +152,11 @@ class PreferencesSystem {
             return defaultPrefs
         }
 
-        return allFieldPrefs[miraName]
+        const defaultPrefs = defaultFieldPreferences()
+        const mergedPrefs = { ...defaultPrefs, ...allFieldPrefs[miraName] }
+        allFieldPrefs[miraName] = mergedPrefs
+
+        return mergedPrefs
     }
 
     /** @returns Preferences for every field that was found in local storage. */
@@ -170,7 +178,12 @@ class PreferencesSystem {
     public static getMotorPreferences(miraName: string): MotorPreferences {
         const allMotorPrefs = this.getAllMotorPreferences()
 
-        allMotorPrefs[miraName] ??= defaultMotorPreferences(miraName)
+        if (allMotorPrefs[miraName] == undefined) {
+            allMotorPrefs[miraName] = defaultMotorPreferences(miraName)
+        } else {
+            const defaultPrefs = defaultMotorPreferences(miraName)
+            allMotorPrefs[miraName] = { ...defaultPrefs, ...allMotorPrefs[miraName] }
+        }
 
         return allMotorPrefs[miraName]
     }
@@ -194,6 +207,10 @@ class PreferencesSystem {
         if (graphicsPrefs == undefined) {
             graphicsPrefs = defaultGraphicsPreferences()
             this._preferences[GRAPHICS_PREFERENCE_KEY] = graphicsPrefs
+        } else {
+            const defaultPrefs = defaultGraphicsPreferences()
+            graphicsPrefs = { ...defaultPrefs, ...graphicsPrefs }
+            this._preferences[GRAPHICS_PREFERENCE_KEY] = graphicsPrefs
         }
 
         return graphicsPrefs