refactor ManagedStorage for save get (#727)

Author: Sneezry

src/background.ts

@@ -508,7 +508,7 @@ async function uploadBackup(service: string) {
 chrome.runtime.onInstalled.addListener(async (details) => {
   if (details.reason !== "install") {
     return;
-  } else if (await ManagedStorage.get("disableInstallHelp")) {
+  } else if (await ManagedStorage.get("disableInstallHelp", false)) {
     return;
   }
 
@@ -565,7 +565,9 @@ chrome.commands.onCommand.addListener(async (command: string) => {
 });
 
 async function setAutolock() {
-  const enforcedAutolock = Number(await ManagedStorage.get("enforceAutolock"));
+  const enforcedAutolock = Number(
+    await ManagedStorage.get("enforceAutolock", false)
+  );
 
   if (enforcedAutolock && enforcedAutolock > 0) {
     autolockTimeout = window.setTimeout(() => {

src/definitions/module-interface.d.ts

@@ -36,7 +36,7 @@ interface MenuState {
   smartFilter: boolean;
   theme: string;
   backupDisabled: boolean;
-  storageArea: string;
+  storageArea: "sync" | "local";
 }
 
 interface StyleState {

src/models/storage.ts

@@ -4,7 +4,9 @@ import * as uuid from "uuid/v4";
 
 export class BrowserStorage {
   private static async getStorageLocation() {
-    const managedLocation = await ManagedStorage.get("storageArea");
+    const managedLocation = await ManagedStorage.get<"sync" | "local">(
+      "storageArea"
+    );
     if (managedLocation === "sync" || managedLocation === "local") {
       return new Promise((resolve) => {
         if (localStorage.storageLocation !== managedLocation) {
@@ -654,18 +656,20 @@ export class EntryStorage {
 }
 
 export class ManagedStorage {
-  static get(key: string) {
-    return new Promise((resolve: (result: boolean | string) => void) => {
+  static get<T>(key: string): T | undefined;
+  static get<T>(key: string, defaultValue: T): T;
+  static get<T>(key: string, defaultValue?: T) {
+    return new Promise((resolve: (result: T | undefined) => void) => {
       chrome.storage.managed.get((data) => {
         if (chrome.runtime.lastError) {
-          return resolve(false);
+          return resolve(defaultValue);
         }
         if (data) {
           if (data[key]) {
             return resolve(data[key]);
           }
         }
-        return resolve(false);
+        return resolve(defaultValue);
       });
     });
   }

src/store/Menu.ts

@@ -12,14 +12,16 @@ export class Menu implements Module {
           localStorage.theme ||
           (localStorage.highContrast === "true" ? "accessibility" : "normal"),
         autolock: Number(localStorage.autolock) || 0,
-        backupDisabled: await ManagedStorage.get("disableBackup"),
-        exportDisabled: await ManagedStorage.get("disableExport"),
-        enforcePassword: await ManagedStorage.get("enforcePassword"),
-        enforceAutolock: await ManagedStorage.get("enforceAutolock"),
-        storageArea: await ManagedStorage.get("storageArea"),
-        feedbackURL: await ManagedStorage.get("feedbackURL"),
-        passwordPolicy: await ManagedStorage.get("passwordPolicy"),
-        passwordPolicyHint: await ManagedStorage.get("passwordPolicyHint"),
+        backupDisabled: await ManagedStorage.get("disableBackup", false),
+        exportDisabled: await ManagedStorage.get("disableExport", false),
+        enforcePassword: await ManagedStorage.get("enforcePassword", false),
+        enforceAutolock: await ManagedStorage.get("enforceAutolock", false),
+        storageArea: await ManagedStorage.get<"sync" | "local">("storageArea"),
+        feedbackURL: await ManagedStorage.get<string>("feedbackURL"),
+        passwordPolicy: await ManagedStorage.get<string>("passwordPolicy"),
+        passwordPolicyHint: await ManagedStorage.get<string>(
+          "passwordPolicyHint"
+        ),
       },
       mutations: {
         setZoom: (state: MenuState, zoom: number) => {