Skip to content

Commit 0eda159

Browse files
committed
isFirefox
1 parent 88ee90e commit 0eda159

File tree

5 files changed

+12
-8
lines changed

5 files changed

+12
-8
lines changed

src/background.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { getSiteName, getMatchedEntries } from "./utils";
1212
import { CodeState } from "./models/otp";
1313

1414
import { getOTPAuthPerLineFromOPTAuthMigration } from "./models/migration";
15-
import { isChrome } from "./browser";
15+
import { isChrome, isFirefox } from "./browser";
1616

1717
let cachedPassphrase = "";
1818
let autolockTimeout: number;
@@ -319,7 +319,7 @@ function getBackupToken(service: string) {
319319
} else if (service === "drive") {
320320
if (navigator.userAgent.indexOf("Edg") !== -1) {
321321
redirUrl = encodeURIComponent("https://authenticator.cc/oauth-edge");
322-
} else if (navigator.userAgent.indexOf("Firefox") !== -1) {
322+
} else if (isFirefox) {
323323
redirUrl = encodeURIComponent(chrome.identity.getRedirectURL());
324324
} else {
325325
redirUrl = encodeURIComponent("https://authenticator.cc/oauth");
@@ -660,7 +660,7 @@ function updateContextMenu() {
660660
encodeURIComponent(tab.title);
661661
}
662662
let windowType;
663-
if (navigator.userAgent.indexOf("Firefox") !== -1) {
663+
if (isFirefox) {
664664
windowType = "detached_panel";
665665
} else {
666666
windowType = "panel";

src/browser.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ const userAgent = navigator.userAgent;
22

33
export const isFirefox = (userAgent.indexOf('Firefox') >= 0);
44
export const isWebKit = (userAgent.indexOf('AppleWebKit') >= 0);
5+
export const isEdge = navigator.userAgent.indexOf("Edg") !== -1);
56
export const isChromium = (userAgent.indexOf('Chrome') >= 0);
67
export const isSafari = (!isChromium && (userAgent.indexOf('Safari') >= 0));
78
export const isChrome = navigator.userAgent.indexOf("Chrome") !== -1 && navigator.userAgent.indexOf("Edg") === -1;

src/components/Popup/MainHeader.vue

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ import IconScan from "../../../svg/scan.svg";
8484
import IconPencil from "../../../svg/pencil.svg";
8585
import IconCheck from "../../../svg/check.svg";
8686
import IconPlus from "../../../svg/plus.svg";
87+
import { isFirefox } from "../../browser";
8788
8889
const computedPrototype = [
8990
mapState("style", ["style"]),
@@ -106,7 +107,7 @@ export default Vue.extend({
106107
},
107108
popOut() {
108109
let windowType;
109-
if (navigator.userAgent.indexOf("Firefox") !== -1) {
110+
if (isFirefox) {
110111
windowType = "detached_panel";
111112
} else {
112113
windowType = "panel";
@@ -152,7 +153,7 @@ export default Vue.extend({
152153
return;
153154
}
154155
// Request permissions
155-
if (navigator.userAgent.indexOf("Firefox") !== -1) {
156+
if (isFirefox) {
156157
await new Promise((resolve: (value: void) => void) => {
157158
chrome.permissions.request(
158159
{ origins: ["<all_urls>"] },

src/components/Popup/MenuPage.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ import IconComments from "../../../svg/comments.svg";
8383
import IconGlobe from "../../../svg/globe.svg";
8484
import IconCode from "../../../svg/code.svg";
8585
import IconClipboardCheck from "../../../svg/clipboard-check.svg";
86+
import { isFirefox } from "../../browser";
8687
8788
export default Vue.extend({
8889
components: {
@@ -111,7 +112,7 @@ export default Vue.extend({
111112
openHelp() {
112113
let url = "https://otp.ee/chromeissues";
113114
114-
if (navigator.userAgent.indexOf("Firefox") !== -1) {
115+
if (isFirefox) {
115116
url = "https://otp.ee/firefoxissues";
116117
} else if (navigator.userAgent.indexOf("Edg") !== -1) {
117118
url = "https://otp.ee/edgeissues";

src/components/Popup/PreferencesPage.vue

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@
6161
</template>
6262
<script lang="ts">
6363
import Vue from "vue";
64+
import { isFirefox } from "../../browser";
6465
6566
export default Vue.extend({
6667
computed: {
@@ -136,7 +137,7 @@ export default Vue.extend({
136137
},
137138
isFirefox: {
138139
get(): boolean {
139-
return navigator.userAgent.indexOf("Firefox") !== -1;
140+
return isFirefox;
140141
},
141142
},
142143
},
@@ -149,7 +150,7 @@ export default Vue.extend({
149150
methods: {
150151
popOut() {
151152
let windowType;
152-
if (navigator.userAgent.indexOf("Firefox") !== -1) {
153+
if (isFirefox) {
153154
windowType = "detached_panel";
154155
} else {
155156
windowType = "panel";

0 commit comments

Comments
 (0)