fix: set cwd based on ESLint directory; fixes #13

Co-authored-by: Andrew Dupont <github@andrewdupont.net>

Author: brettz9

lib/worker.js

@@ -365,6 +365,9 @@ async function processMessage (bundle) {
     return;
   }
 
+  const oldCwd = process.cwd();
+  process.chdir(eslint.cwd);
+
   if (type === 'debug') {
     let { eslintPath, eslintVersion, isBuiltIn } = eslint;
     let isIncompatible = compareVersions(eslintVersion, MINIMUM_ESLINT_VERSION) < 1;
@@ -379,6 +382,7 @@ async function processMessage (bundle) {
       isBuiltIn,
       workerPid: process.pid
     });
+    process.chdir(oldCwd);
     return;
   }
 
@@ -417,6 +421,8 @@ async function processMessage (bundle) {
     emitError(
       JSON.stringify(error, Object.getOwnPropertyNames(error))
     );
+  } finally {
+    process.chdir(oldCwd);
   }
 }
 

spec/fixtures/dynamic-cwd/.eslintignore

@@ -0,0 +1,27 @@
+const { join } = require('path');
+
+const getEcmaVersionForNodeVersion = (nodeVersion) => {
+  if (nodeVersion === '16.0.0') {
+    return 'es2021';
+  }
+
+  // Would really need to do more detection
+  return 'es2015';
+};
+
+const detectNodeVersion = (packagePath) => {
+  const { engines: { node } } = require(packagePath);
+
+  // Would really want to use semver.minVersion, wrap in try-catch, etc.
+  return node;
+};
+
+const nodeVersion = detectNodeVersion(join(process.cwd(), 'package.json'));
+const ecmaVersion = getEcmaVersionForNodeVersion(nodeVersion);
+
+module.exports = {
+  "root": true,
+  "env": {
+    [ecmaVersion]: true
+  }
+};

spec/fixtures/dynamic-cwd/.eslintrc.js

@@ -0,0 +1,5 @@
+let a = true;
+
+a ||= false;
+
+console.log(a);

spec/fixtures/dynamic-cwd/logical-or-assignment.js

@@ -0,0 +1,5 @@
+{
+  "engines": {
+    "node": "16.0.0"
+  }
+}

spec/fixtures/dynamic-cwd/package.json

@@ -16,6 +16,7 @@ const paths = {
   good: path.join(fixturesDir, 'files', 'with-config', 'good.js'),
   bad: path.join(fixturesDir, 'files', 'with-config', 'bad.js'),
   badInline: path.join(fixturesDir, 'files', 'inline', 'badInline.js'),
+  dynamicCwd: path.join(fixturesDir, 'dynamic-cwd', 'logical-or-assignment.js'),
   empty: path.join(fixturesDir, 'files', 'with-config', 'empty.js'),
   fix: path.join(fixturesDir, 'files', 'with-config', 'fix.js'),
   cache: path.join(fixturesDir, 'files', 'with-config', '.eslintcache'),
@@ -166,6 +167,18 @@ describe('The eslint provider for Linter', () => {
     expect(messages.length).toBe(0);
   });
 
+  it('finds no cwd problems with a valid file (and proper dynamic ecmaVersion)', async () => {
+    const cwd = process.cwd();
+
+    const editor = await atom.workspace.open(paths.dynamicCwd);
+    const messages = await lint(editor);
+
+    expect(cwd).toEqual(process.cwd());
+    process.chdir(cwd);
+
+    expect(messages.length).toBe(0);
+  });
+
   it('reports the fixes for fixable errors', async () => {
     const editor = await atom.workspace.open(paths.fix);
     const messages = await lint(editor);