Rename __start to _start (#994)

Author: dcodeIO

lib/loader/README.md

@@ -30,7 +30,7 @@ API
 
 Besides demangling classes exported from your entry file to a handy object structure one can use like JS objects, instances are automatically populated with useful utility:
 
-* **__start**(): `void`<br />
+* **_start**(): `void`<br />
   Explicit start function if the `--explicitStart` option is used. Must be called before any other exports if present.
 
 * **__allocString**(str: `string`): `number`<br />

lib/loader/index.d.ts

@@ -16,7 +16,7 @@ interface ASUtil {
   table?: WebAssembly.Table;
 
   /** Explicit start function, if requested. */
-  __start(): void;
+  _start(): void;
   /** Allocates a new string in the module's memory and returns a reference (pointer) to it. */
   __allocString(str: string): number;
   /** Reads (copies) the value of a string from the module's memory. */

src/compiler.ts

@@ -404,7 +404,7 @@ export class Compiler extends DiagnosticEmitter {
       );
       startFunctionInstance.finalize(module, funcRef);
       if (!explicitStart) module.setStart(funcRef);
-      else module.addFunctionExport(startFunctionInstance.internalName, "__start");
+      else module.addFunctionExport(startFunctionInstance.internalName, "_start");
     }
 
     // compile runtime features

tests/compiler.js

@@ -324,9 +324,9 @@ function testInstantiate(basename, binaryBuffer, name, glue) {
       }
       var instance = new WebAssembly.Instance(new WebAssembly.Module(binaryBuffer), imports);
       Object.setPrototypeOf(exports, instance.exports);
-      if (exports.__start) {
+      if (exports._start) {
         console.log(colorsUtil.white("  [start]"));
-        exports.__start();
+        exports._start();
       }
       if (glue.postInstantiate) {
         console.log(colorsUtil.white("  [postInstantiate]"));

tests/compiler/features/js-bigint-integration.optimized.wat

@@ -9,7 +9,7 @@
  (data (i32.const 16) "B\00\00\00\01\00\00\00\01\00\00\00B\00\00\00f\00e\00a\00t\00u\00r\00e\00s\00/\00j\00s\00-\00b\00i\00g\00i\00n\00t\00-\00i\00n\00t\00e\00g\00r\00a\00t\00i\00o\00n\00.\00t\00s")
  (global $features/js-bigint-integration/internalValue i64 (i64.const 9007199254740991))
  (global $~lib/started (mut i32) (i32.const 0))
- (export "__start" (func $start))
+ (export "_start" (func $start))
  (export "memory" (memory $0))
  (export "internalValue" (global $features/js-bigint-integration/internalValue))
  (export "getInternalValue" (func $features/js-bigint-integration/getInternalValue))

tests/compiler/features/js-bigint-integration.untouched.wat

@@ -10,7 +10,7 @@
  (table $0 1 funcref)
  (global $features/js-bigint-integration/internalValue i64 (i64.const 9007199254740991))
  (global $~lib/started (mut i32) (i32.const 0))
- (export "__start" (func $start))
+ (export "_start" (func $start))
  (export "memory" (memory $0))
  (export "internalValue" (global $features/js-bigint-integration/internalValue))
  (export "getInternalValue" (func $features/js-bigint-integration/getInternalValue))

tests/compiler/features/mutable-globals.optimized.wat

@@ -7,7 +7,7 @@
  (data (i32.const 16) "6\00\00\00\01\00\00\00\01\00\00\006\00\00\00f\00e\00a\00t\00u\00r\00e\00s\00/\00m\00u\00t\00a\00b\00l\00e\00-\00g\00l\00o\00b\00a\00l\00s\00.\00t\00s")
  (global $features/mutable-globals/internal (mut i32) (i32.const 124))
  (global $~lib/started (mut i32) (i32.const 0))
- (export "__start" (func $start))
+ (export "_start" (func $start))
  (export "memory" (memory $0))
  (export "external" (global $features/mutable-globals/external))
  (export "internal" (global $features/mutable-globals/internal))

tests/compiler/features/mutable-globals.untouched.wat

@@ -8,7 +8,7 @@
  (table $0 1 funcref)
  (global $features/mutable-globals/internal (mut i32) (i32.const 124))
  (global $~lib/started (mut i32) (i32.const 0))
- (export "__start" (func $start))
+ (export "_start" (func $start))
  (export "memory" (memory $0))
  (export "external" (global $features/mutable-globals/external))
  (export "internal" (global $features/mutable-globals/internal))

tests/compiler/retain-release.optimized.wat

@@ -17,7 +17,7 @@
  (global $retain-release/TARGET (mut i32) (i32.const 0))
  (global $~lib/argc (mut i32) (i32.const 0))
  (global $~lib/started (mut i32) (i32.const 0))
- (export "__start" (func $start))
+ (export "_start" (func $start))
  (export "memory" (memory $0))
  (export "returnRef" (func $retain-release/returnRef))
  (export "receiveRef" (func $retain-release/receiveRef))

tests/compiler/retain-release.untouched.wat

@@ -18,7 +18,7 @@
  (global $~lib/argc (mut i32) (i32.const 0))
  (global $~lib/started (mut i32) (i32.const 0))
  (global $~lib/heap/__heap_base i32 (i32.const 100))
- (export "__start" (func $start))
+ (export "_start" (func $start))
  (export "memory" (memory $0))
  (export "returnRef" (func $retain-release/returnRef))
  (export "receiveRef" (func $retain-release/receiveRef))