revert #1353: revert runtime type check to compile time check for Array#flat (#2416)

Author: HerrCai0907

NOTICE

@@ -42,7 +42,7 @@ under the licensing terms detailed in LICENSE:
 * Roman F. <70765447+romdotdog@users.noreply.github.com>
 * Joe Pea <trusktr@gmail.com>
 * Felipe Gasper <FGasper@users.noreply.github.com>
-* Congcong Cai <77575210+HerrCai0907@users.noreply.github.com>
+* Congcong Cai <congcongcai0907@163.com>
 * mooooooi <emwings@outlook.com>
 * Yasushi Ando <andyjpn@gmail.com>
 * Syed Jafri <syed@metalpay.co>

std/assembly/array.ts

@@ -6,7 +6,7 @@ import { COMPARATOR, SORT } from "./util/sort";
 import { REVERSE, FILL } from "./util/bytes";
 import { joinBooleanArray, joinIntegerArray, joinFloatArray, joinStringArray, joinReferenceArray } from "./util/string";
 import { idof, isArray as builtin_isArray } from "./builtins";
-import { E_INDEXOUTOFRANGE, E_INVALIDLENGTH, E_ILLEGALGENTYPE, E_EMPTYARRAY, E_HOLEYARRAY } from "./util/error";
+import { E_INDEXOUTOFRANGE, E_INVALIDLENGTH, E_EMPTYARRAY, E_HOLEYARRAY } from "./util/error";
 
 // @ts-ignore: decorator
 @inline @lazy const MIN_SIZE: usize = 8;
@@ -450,7 +450,7 @@ export class Array<T> {
 
   flat(): T {
     if (!isArray<T>()) {
-      throw new TypeError(E_ILLEGALGENTYPE);
+      ERROR("Cannot call flat() on Array<T> where T is not an Array.");
     }
     // Get the length and data start values
     var ptr = this.dataStart;

std/assembly/util/error.ts

@@ -13,10 +13,6 @@ export const E_VALUEOUTOFRANGE: string = "Value out of range";
 @lazy @inline
 export const E_INVALIDLENGTH: string = "Invalid length";
 
-// @ts-ignore: decorator
-@lazy @inline
-export const E_ILLEGALGENTYPE: string = "Illegal generic type";
-
 // @ts-ignore: decorator
 @lazy @inline
 export const E_EMPTYARRAY: string = "Array is empty";