fix: Make warning 232 pedantic (#1986)

Willem Wyndham · web-flow · commit 3a33a253b6bb · 2021-07-23T17:32:27.000+03:00
diff --git a/src/compiler.ts b/src/compiler.ts
@@ -799,10 +799,12 @@ export class Compiler extends DiagnosticEmitter {
             this.ensureModuleExport(instanceName, instance, prefix);
           }
         } else if (functionPrototype.is(CommonFlags.GENERIC)) {
-          this.warning(
-            DiagnosticCode.Exported_generic_function_or_class_has_no_concrete_instances,
-            functionPrototype.identifierNode.range
-          );
+          if (this.options.pedantic) {
+            this.pedantic(
+              DiagnosticCode.Exported_generic_function_or_class_has_no_concrete_instances,
+              functionPrototype.identifierNode.range
+            );
+          }
         }
         break;
       }
@@ -821,10 +823,12 @@ export class Compiler extends DiagnosticEmitter {
             this.ensureModuleExport(instanceName, instance, prefix);
           }
         } else if (classPrototype.is(CommonFlags.GENERIC)) {
-          this.warning(
-            DiagnosticCode.Exported_generic_function_or_class_has_no_concrete_instances,
-            classPrototype.identifierNode.range
-          );
+          if (this.options.pedantic) {
+            this.pedantic(
+              DiagnosticCode.Exported_generic_function_or_class_has_no_concrete_instances,
+              classPrototype.identifierNode.range
+            );
+          }
         }
         break;
       }
diff --git a/tests/compiler/export-generic.json b/tests/compiler/export-generic.json
@@ -1,5 +1,6 @@
 {
   "asc_flags": [
+    "--pedantic"
   ],
   "stderr": [
     "AS232: Exported generic function or class has no concrete instances.",

Original file line number	Diff line number	Diff line change
`@@ -799,10 +799,12 @@ export class Compiler extends DiagnosticEmitter {`
`799`	`799`	`this.ensureModuleExport(instanceName, instance, prefix);`
`800`	`800`	`}`
`801`	`801`	`} else if (functionPrototype.is(CommonFlags.GENERIC)) {`
`802`		`- this.warning(`
`803`		`- DiagnosticCode.Exported_generic_function_or_class_has_no_concrete_instances,`
`804`		`- functionPrototype.identifierNode.range`
`805`		`- );`
	`802`	`+ if (this.options.pedantic) {`
	`803`	`+ this.pedantic(`
	`804`	`+ DiagnosticCode.Exported_generic_function_or_class_has_no_concrete_instances,`
	`805`	`+ functionPrototype.identifierNode.range`
	`806`	`+ );`
	`807`	`+ }`
`806`	`808`	`}`
`807`	`809`	`break;`
`808`	`810`	`}`
`@@ -821,10 +823,12 @@ export class Compiler extends DiagnosticEmitter {`
`821`	`823`	`this.ensureModuleExport(instanceName, instance, prefix);`
`822`	`824`	`}`
`823`	`825`	`} else if (classPrototype.is(CommonFlags.GENERIC)) {`
`824`		`- this.warning(`
`825`		`- DiagnosticCode.Exported_generic_function_or_class_has_no_concrete_instances,`
`826`		`- classPrototype.identifierNode.range`
`827`		`- );`
	`826`	`+ if (this.options.pedantic) {`
	`827`	`+ this.pedantic(`
	`828`	`+ DiagnosticCode.Exported_generic_function_or_class_has_no_concrete_instances,`
	`829`	`+ classPrototype.identifierNode.range`
	`830`	`+ );`
	`831`	`+ }`
`828`	`832`	`}`
`829`	`833`	`break;`
`830`	`834`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"asc_flags": [`
	`3`	`+ "--pedantic"`
`3`	`4`	`],`
`4`	`5`	`"stderr": [`
`5`	`6`	`"AS232: Exported generic function or class has no concrete instances.",`