ÂAdded tests for IdentifierCollection

Author: Art4

tests/unit/Resource/IdentifierCollection.php renamed to tests/unit/Resource/IdentifierCollectionTest.php

@@ -57,25 +57,8 @@ public function testCreateWithIdentifier()
 		$this->assertSame($collection->getKeys(), array(0, 1, 2));
 
 		$this->assertTrue($collection->has(0));
-		$resource = $collection->get(0);
-
-		$this->assertInstanceOf('Art4\JsonApiClient\Resource\ResourceInterface', $resource);
-		$this->assertInstanceOf('Art4\JsonApiClient\Resource\Identifier', $resource);
-		$this->assertNotInstanceOf('Art4\JsonApiClient\Resource\Item', $resource);
-
 		$this->assertTrue($collection->has(1));
-		$resource = $collection->get(1);
-
-		$this->assertInstanceOf('Art4\JsonApiClient\Resource\ResourceInterface', $resource);
-		$this->assertInstanceOf('Art4\JsonApiClient\Resource\Identifier', $resource);
-		$this->assertInstanceOf('Art4\JsonApiClient\Resource\Item', $resource);
-
 		$this->assertTrue($collection->has(2));
-		$resource = $collection->get(2);
-
-		$this->assertInstanceOf('Art4\JsonApiClient\Resource\ResourceInterface', $resource);
-		$this->assertInstanceOf('Art4\JsonApiClient\Resource\Identifier', $resource);
-		$this->assertNotInstanceOf('Art4\JsonApiClient\Resource\Item', $resource);
 
 		$this->assertSame($collection->asArray(), array(
 			$collection->get(0),
@@ -108,7 +91,7 @@ public function testCreateWithItem()
 		$this->assertInstanceOf('Art4\JsonApiClient\Resource\Collection', $collection);
 
 		$this->assertTrue($collection->isCollection());
-		$this->assertCount($collection->asArray(), 1);
+		$this->assertCount(1, $collection->asArray());
 		$this->assertSame($collection->getKeys(), array(0));
 		$this->assertTrue($collection->has(0));
 
@@ -140,22 +123,6 @@ public function testCreateWithoutArrayThrowsException($input)
 		$collection = new IdentifierCollection($input, $this->manager);
 	}
 
-	/**
-	 * @dataProvider jsonValuesProvider
-	 */
-	public function testCreateWithoutObjectInArrayThrowsException($input)
-	{
-		// Input must be an object
-		if ( gettype($input) === 'object' )
-		{
-			return;
-		}
-
-		$this->setExpectedException('Art4\JsonApiClient\Exception\ValidationException');
-
-		$collection = new IdentifierCollection(array($input), $this->manager);
-	}
-
 	/**
 	 * @test get('resources') on an empty identifier collection throws an exception
 	 */
@@ -167,7 +134,10 @@ public function testGetResourcesWithEmptyCollectionThrowsException()
 
 		$this->assertFalse($collection->has(0));
 
-		$this->setExpectedException('Art4\JsonApiClient\Exception\AccessException');
+		$this->setExpectedException(
+			'Art4\JsonApiClient\Exception\AccessException',
+			'"0" doesn\'t exist in this resource.'
+		);
 
 		$collection->get(0);
 	}