Merge pull request #66 from Art4/phpstan-level-6

Fix all errors for PHPStan Level 6

Author: Art4

.github/workflows/phpstan.yml

@@ -49,6 +49,6 @@ jobs:
         run: composer install --no-progress --prefer-dist --optimize-autoloader
 
       - name: Run PHPStan
-        run: vendor/bin/phpstan.phar analyze src --level 5
+        run: vendor/bin/phpstan.phar analyze src --level 6
 
       - run: echo "🍏 This job's status is ${{ job.status }}."

src/Accessable.php

@@ -45,7 +45,7 @@ public function has($key);
     /**
      * Returns the keys of all setted values
      *
-     * @return array Keys of all setted values
+     * @return array<string> Keys of all setted values
      */
     public function getKeys();
 }

src/Factory.php

@@ -30,7 +30,7 @@ interface Factory
      * Create a new instance of a class
      *
      * @param string $name
-     * @param array  $args
+     * @param array<mixed|Manager|Accessable>  $args
      *
      * @return \Art4\JsonApiClient\Accessable
      */

src/Helper/AbstractElement.php

@@ -97,6 +97,8 @@ protected function create($name, $data)
      * Parse the data
      *
      * @param mixed $data
+     *
+     * @return void
      */
     abstract protected function parse($data);
 }

src/Helper/AccessKey.php

@@ -33,7 +33,7 @@ final class AccessKey extends SplStack
      *
      * @param mixed $key
      *
-     * @return AccessKey
+     * @return AccessKey<string>
      */
     public static function create($key)
     {

src/Helper/AccessableTrait.php

@@ -30,7 +30,7 @@
 trait AccessableTrait
 {
     /**
-     * @var array
+     * @var array<mixed>
      */
     private $data = [];
 
@@ -57,7 +57,7 @@ protected function set($key, $value)
     /**
      * Returns the keys of all setted values
      *
-     * @return array Keys of all setted values
+     * @return array<string> Keys of all setted values
      */
     public function getKeys()
     {
@@ -144,9 +144,9 @@ private function getValue($key)
     /**
      * Parse a dot.notated.key to an object
      *
-     * @param string|AccessKey $key The key
+     * @param string|AccessKey<string> $key The key
      *
-     * @return AccessKey The parsed key
+     * @return AccessKey<string> The parsed key
      */
     private function parseKey($key)
     {

src/Input/RequestStringInput.php

@@ -26,7 +26,7 @@ final class RequestStringInput implements Input, RequestInput
 {
     use StringInputTrait;
 
-    private $rawString;
+    private string $rawString;
 
     /**
      * Set the input

src/Input/ResponseStringInput.php

@@ -26,7 +26,7 @@ final class ResponseStringInput implements Input
 {
     use StringInputTrait;
 
-    private $rawString;
+    private string $rawString;
 
     /**
      * Set the input

src/Manager/ErrorAbortManager.php

@@ -31,11 +31,13 @@
  */
 final class ErrorAbortManager implements Manager
 {
-    private $factory;
+    private Factory $factory;
 
-    private $config = [];
+    /** @var array<string, mixed> */
+    private array $config = [];
 
-    private $default = [
+    /** @var array<string, mixed> */
+    private array $default = [
         'optional_item_id' => false,
     ];
 

src/Serializer/ArraySerializer.php

@@ -24,14 +24,15 @@
 
 final class ArraySerializer implements Serializer
 {
-    private $config = [
+    /** @var array<string, mixed> */
+    private array $config = [
         'recursive' => false,
     ];
 
     /**
      * Setup the serializer
      *
-     * @param array $params
+     * @param array<string, mixed> $params
      */
     public function __construct(array $params = [])
     {
@@ -47,7 +48,7 @@ public function __construct(array $params = [])
      *
      * @param \Art4\JsonApiClient\Accessable $data The data for serialization
      *
-     * @return array|null
+     * @return array<string, mixed>|null
      */
     public function serialize(Accessable $data)
     {