Fix builtin-platform logic, by removing it entirely

Author: ianfixes

CHANGELOG.md

@@ -29,6 +29,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Removed
 - `ARDUINO_CI_SKIP_SPLASH_SCREEN_RSPEC_TESTS` no longer affects any tests because there are no longer splash screens since switching to `arduino-cli`
+- `CIConfig.package_builtin?` as this is no longer relevant to the `arduino-cli` backend (which has no built-in packages)
 
 ### Fixed
 - Mismatches between library names in `library.properties` and the directory names, which can cause cryptic failures

exe/arduino_ci.rb

@@ -310,29 +310,22 @@ def perform_example_compilation_tests(cpp_library, config)
   # do that, set the URLs, and download the packages
   all_packages = example_platform_info.values.map { |v| v[:package] }.uniq.reject(&:nil?)
 
-  builtin_packages, external_packages = all_packages.partition { |p| config.package_builtin?(p) }
-
-  # inform about builtin packages
-  builtin_packages.each do |p|
-    inform("Using built-in board package") { p }
-  end
-
   # make sure any non-builtin package has a URL defined
-  external_packages.each do |p|
+  all_packages.each do |p|
     assure("Board package #{p} has a defined URL") { board_package_url[p] }
   end
 
   # set up all the board manager URLs.
   # we can safely reject nils now, they would be for the builtins
-  all_urls = external_packages.map { |p| board_package_url[p] }.uniq.reject(&:nil?)
+  all_urls = all_packages.map { |p| board_package_url[p] }.uniq.reject(&:nil?)
 
   unless all_urls.empty?
     assure("Setting board manager URLs") do
       @backend.board_manager_urls = all_urls
     end
   end
 
-  external_packages.each do |p|
+  all_packages.each do |p|
     assure("Installing board package #{p}") do
       @backend.install_boards(p)
     end

lib/arduino_ci/ci_config.rb

@@ -232,13 +232,6 @@ def platform_definition(platform_name)
       deep_clone(defn)
     end
 
-    # Whether a package is built-in to arduino
-    # @param package [String] the package name (e.g. "arduino:avr")
-    # @return [bool]
-    def package_builtin?(package)
-      package.start_with?("arduino:")
-    end
-
     # the URL that gives the download info for a given package (a JSON file).
     # this is NOT where the package comes from.
     # @param package [String] the package name (e.g. "arduino:avr")

misc/default.yml

@@ -3,8 +3,12 @@
 #   https://en.wikipedia.org/wiki/List_of_Arduino_boards_and_compatible_systems
 
 packages:
-  # arduino:xxx are builtin, we don't need to include them here
-  # but if we did, it would be url: https://downloads.arduino.cc/packages/package_index.json
+  arduino:avr:
+    url: https://downloads.arduino.cc/packages/package_index.json
+  arduino:sam:
+    url: https://downloads.arduino.cc/packages/package_index.json
+  arduino:samd:
+    url: https://downloads.arduino.cc/packages/package_index.json
   esp8266:esp8266:
     url: http://arduino.esp8266.com/stable/package_esp8266com_index.json
   adafruit:avr:

spec/ci_config_spec.rb

@@ -27,9 +27,6 @@
       expect(zero[:package]).to eq("arduino:samd")
       expect(zero[:gcc].class).to eq(Hash)
 
-      expect(default_config.package_builtin?("arduino:avr")).to be true
-      expect(default_config.package_builtin?("adafruit:avr")).to be false
-
       expect(default_config.package_url("adafruit:avr")).to eq("https://adafruit.github.io/arduino-board-index/package_adafruit_index.json")
       expect(default_config.package_url("adafruit:samd")).to eq("https://adafruit.github.io/arduino-board-index/package_adafruit_index.json")
       expect(default_config.package_url("esp32:esp32")).to eq("https://dl.espressif.com/dl/package_esp32_index.json")