File tree Expand file tree Collapse file tree 2 files changed +8
-1
lines changed Expand file tree Collapse file tree 2 files changed +8
-1
lines changed Original file line number Diff line number Diff line change @@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
1818### Removed
1919
2020### Fixed
21+ - Determining a working OSX launch command no longer breaks on non-English installations
2122
2223### Security
2324
Original file line number Diff line number Diff line change @@ -80,7 +80,13 @@ def autolocate_osx
8080 # don't want to see is a java error.
8181 args = launcher + [ "--bogus-option" ]
8282 result = Host . run_and_capture ( *args )
83- next unless result [ :err ] . include? "Error: unknown option: --bogus-option"
83+
84+ # NOTE: Was originally searching for "Error: unknown option: --bogus-option"
85+ # but also need to find "Erreur: option inconnue : --bogus-option"
86+ # and who knows how many other languages.
87+ # For now, just search for the end of the error and hope that the java-style
88+ # launch of this won't include a similar string in it
89+ next unless result [ :err ] . include? ": --bogus-option"
8490
8591 ret . base_cmd = launcher
8692 ret . binary_path = Pathname . new ( osx_root )
You can’t perform that action at this time.
0 commit comments