Fix library.properties parse error handling

Author: ianfixes

CHANGELOG.md

@@ -30,6 +30,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Fixed
 - Mismatches between library names in `library.properties` and the directory names, which can cause cryptic failures
+- `LibraryProperties` skips over parse errors instead of crashing: only lines with non-empty keys and non-nil values are recorded
 
 ### Security
 

lib/arduino_ci/library_properties.rb

@@ -11,9 +11,14 @@ class LibraryProperties
     # @param path [Pathname] The path to the library.properties file
     def initialize(path)
       @fields = {}
-      File.foreach(path) do |line|
+      File.foreach(path) do |line_with_delim|
+        line = line_with_delim.chomp
         parts = line.split("=", 2)
-        @fields[parts[0]] = parts[1].chomp unless parts.empty?
+        next if parts[0].nil?
+        next if parts[0].empty?
+        next if parts[1].nil?
+
+        @fields[parts[0]] = parts[1] unless parts[1].empty?
       end
     end
 

spec/library_properties_spec.rb

@@ -3,7 +3,7 @@
 RSpec.describe ArduinoCI::LibraryProperties do
 
   context "property extraction" do
-    library_properties = ArduinoCI::LibraryProperties.new(Pathname.new(__dir__) + "properties/example.library.properties")
+    library_properties = ArduinoCI::LibraryProperties.new(Pathname.new(__dir__) + "properties" + "example.library.properties")
 
     expected = {
       string: {
@@ -48,5 +48,22 @@
     end
   end
 
+  context "Input handling" do
+    malformed_examples = [
+      "extra_blank_line.library.properties",
+      "just_equals.library.properties",
+      "no_equals.library.properties",
+      "no_key.library.properties",
+      "no_value.library.properties",
+    ].map { |e| Pathname.new(__dir__) + "properties" + e }
+
+    malformed_examples.each do |e|
+      quirk = e.basename.to_s.split(".library.").first
+      it "reads a properties file with #{quirk}" do
+        expect { ArduinoCI::LibraryProperties.new(e) }.to_not raise_error
+      end
+    end
+  end
+
 
 end

spec/properties/extra_blank_line.library.properties

@@ -0,0 +1,3 @@
+name=ExtraBlank
+
+sentence=We put the blank line in the middle so overzealous text editors dont trim it

spec/properties/just_equals.library.properties

@@ -0,0 +1,3 @@
+name=JustEquals
+sentence=Bad file with just an equals on a line
+=

spec/properties/no_equals.library.properties

@@ -0,0 +1,3 @@
+name=NoEquals
+sentence=Bad file with no equals on a line
+wat

spec/properties/no_key.library.properties

@@ -0,0 +1,3 @@
+name=NoKey
+sentence=Bad file with no key on a line
+=profit

spec/properties/no_value.library.properties

@@ -0,0 +1,3 @@
+name=NoValue
+sentence=Bad file with no value on a line
+seriously_why_do_we_even_have_this_line=